Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12886024: Move JSON schema validator code into its own directory in chrome/common (Closed)

Created:
7 years, 9 months ago by asargent_no_longer_on_chrome
Modified:
7 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Move JSON schema validator code into its own directory in chrome/common Also add an OWNERS file there with some people who've worked on JSON schema in the extensions/apps system. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188940

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1614 lines) Patch
M chrome/browser/policy/policy_loader_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_loader_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +3 lines, -3 lines 0 comments Download
A chrome/common/json_schema/OWNERS View 1 chunk +5 lines, -0 lines 0 comments Download
A + chrome/common/json_schema/json_schema_constants.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/common/json_schema/json_schema_constants.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/common/json_schema/json_schema_validator.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/common/json_schema/json_schema_validator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/common/json_schema/json_schema_validator_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/common/json_schema/json_schema_validator_unittest_base.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/common/json_schema/json_schema_validator_unittest_base.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D chrome/common/json_schema_constants.h View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/common/json_schema_constants.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/common/json_schema_validator.h View 1 chunk +0 lines, -225 lines 0 comments Download
D chrome/common/json_schema_validator.cc View 1 chunk +0 lines, -496 lines 0 comments Download
D chrome/common/json_schema_validator_unittest.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/common/json_schema_validator_unittest_base.h View 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/common/json_schema_validator_unittest_base.cc View 1 chunk +0 lines, -678 lines 0 comments Download
M chrome/common/web_apps.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/web_apps_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
asargent_no_longer_on_chrome
sky: please review No functional changes, just moving files into a subdirectory.
7 years, 9 months ago (2013-03-18 22:11:14 UTC) #1
sky
LGTM
7 years, 9 months ago (2013-03-18 22:34:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/12886024/1
7 years, 9 months ago (2013-03-18 22:45:37 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-19 03:31:33 UTC) #4
Message was sent while issue was closed. 
Change committed as 188940

Powered by Google App Engine
This is Rietveld 408576698