Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12886018: Add support for WEBKIT_USE_NEW_WEBFILESYSTEMTYPE (Closed)

Created:
7 years, 9 months ago by pilgrim_google
Modified:
7 years, 9 months ago
CC:
chromium-reviews, tzik+watch_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, rginda+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, kinuko+watch
Visibility:
Public.

Description

Add support for WEBKIT_USE_NEW_WEBFILESYSTEMTYPE Upstream WebKit is migrating from WebFileSystem::Type to a new top-level WebFileSystemType (unconnected to the WebFileSystem class) in order to make other filesystem-related refactoring easier. This is behind an #ifdef so that we can make the necessary changes upstream and downstream all at once. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189038

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -10 lines) Patch
M chrome/renderer/extensions/file_browser_handler_custom_bindings.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/file_browser_private_custom_bindings.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/file_system_natives.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/media_galleries_custom_bindings.cc View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/renderer/extensions/sync_file_system_custom_bindings.cc View 1 chunk +6 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +8 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M content/worker/websharedworkerclient_proxy.h View 2 chunks +7 lines, -1 line 0 comments Download
M content/worker/websharedworkerclient_proxy.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/fileapi/file_system_types.h View 3 chunks +14 lines, -0 lines 0 comments Download
M webkit/fileapi/file_system_util.h View 2 chunks +7 lines, -1 line 0 comments Download
M webkit/fileapi/file_system_util.cc View 1 chunk +22 lines, -1 line 0 comments Download
M webkit/support/webkit_support.h View 2 chunks +9 lines, -0 lines 0 comments Download
M webkit/support/webkit_support.cc View 1 chunk +12 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/simple_file_system.h View 2 chunks +9 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/simple_file_system.cc View 2 chunks +12 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.h View 2 chunks +5 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
pilgrim_google
7 years, 9 months ago (2013-03-18 19:25:27 UTC) #1
pilgrim_google
Depends on https://bugs.webkit.org/show_bug.cgi?id=112571 landing and rolling.
7 years, 9 months ago (2013-03-18 19:26:37 UTC) #2
darin (slow to review)
LGTM
7 years, 9 months ago (2013-03-18 21:26:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/12886018/5003
7 years, 9 months ago (2013-03-19 12:54:33 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-03-19 16:37:56 UTC) #5
Message was sent while issue was closed. 
Change committed as 189038

Powered by Google App Engine
This is Rietveld 408576698