src/objects-inl.h - Issue 12886008: Unify kMaxArguments with number of bits used to encode it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 12886008: Unify kMaxArguments with number of bits used to encode it. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index 9a520b24bdce619240668700a82d4829b1b004f2..eeca2747ecb7b2cef3b5cc55bae4e4a987d29b4f 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -3869,8 +3869,9 @@ Code::Flags Code::ComputeFlags(Kind kind,

StubType type,

int argc,

InlineCacheHolderFlag holder) {

+ ASSERT(argc < Code::kMaxArguments);

danno 2013/03/18 13:03:59 Why not <= ?

// Compute the bit mask.

- int bits = KindField::encode(kind)

+ unsigned int bits = KindField::encode(kind)

| ICStateField::encode(ic_state)

| TypeField::encode(type)

| ExtraICStateField::encode(extra_ic_state)

« no previous file with comments | « src/objects.h ('k') | src/parser.h » ('j') | no next file with comments »