Issue 12886008: Unify kMaxArguments with number of bits used to encode it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12886008: Unify kMaxArguments with number of bits used to encode it. (Closed)

Created:
7 years, 9 months ago by Toon Verwaest

Modified:
7 years, 9 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Unify kMaxArguments with number of bits used to encode it. Increase the number of bits by 1 by making Flags unsigned. BUG=chromium:211741 Committed: https://code.google.com/p/v8/source/detail?r=13964

Patch Set 2 : Addressed comment #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -14 lines)			Patch
M	src/objects.h	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	src/objects-inl.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/parser.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/parser.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/stub-cache.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

danno

lgtm with comment https://chromiumcodereview.appspot.com/12886008/diff/1/src/objects-inl.h File src/objects-inl.h (right): https://chromiumcodereview.appspot.com/12886008/diff/1/src/objects-inl.h#newcode3872 src/objects-inl.h:3872: ASSERT(argc < Code::kMaxArguments); Why not <= ...

7 years, 9 months ago (2013-03-18 13:03:59 UTC) #2

Toon Verwaest

7 years, 9 months ago (2013-03-18 13:35:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r13964 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12886008: Unify kMaxArguments with number of bits used to encode it. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comment #

Messages