Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 12880007: Translate some ant to python (Closed)

Created:
7 years, 9 months ago by cjhopman
Modified:
7 years, 9 months ago
Reviewers:
shashi, Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ant_split
Visibility:
Public.

Description

Translate some ant to python This moves java compilation, jar, and dex for apks from ant to python. This uses the same javac.py and jar.py that are used by build/java.gypi for libraries and introduces a simple dex.py. BUG=158821 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190756

Patch Set 1 : #

Total comments: 5

Patch Set 2 : Rebase #

Patch Set 3 : Fix dex for clean builds #

Patch Set 4 : Fix dex for clean builds #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -131 lines) Patch
A + build/android/ant/apk-obfuscate.xml View 1 2 3 4 5 chunks +17 lines, -118 lines 0 comments Download
A build/android/dex.py View 1 2 1 chunk +41 lines, -0 lines 0 comments Download
M build/java.gypi View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M build/java_apk.gypi View 1 2 3 4 5 chunks +111 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
cjhopman
7 years, 9 months ago (2013-03-22 23:53:38 UTC) #1
Yaron
lgtm https://codereview.chromium.org/12880007/diff/13001/build/java_apk.gypi File build/java_apk.gypi (right): https://codereview.chromium.org/12880007/diff/13001/build/java_apk.gypi#newcode235 build/java_apk.gypi:235: '--classpath=>(input_jars_paths) <(android_sdk_jar)', Doesn't this needed to be quoted ...
7 years, 9 months ago (2013-03-23 00:15:11 UTC) #2
shashi
lgtm https://codereview.chromium.org/12880007/diff/13001/build/android/dex.py File build/android/dex.py (right): https://codereview.chromium.org/12880007/diff/13001/build/android/dex.py#newcode18 build/android/dex.py:18: dex_cmd = [dx_binary, '--dex', '--output', options.dex_path] + paths ...
7 years, 9 months ago (2013-03-23 01:00:19 UTC) #3
cjhopman
https://codereview.chromium.org/12880007/diff/13001/build/android/dex.py File build/android/dex.py (right): https://codereview.chromium.org/12880007/diff/13001/build/android/dex.py#newcode19 build/android/dex.py:19: subprocess.check_call(dex_cmd) On 2013/03/23 01:00:19, shashi wrote: > Perhaps, later ...
7 years, 9 months ago (2013-03-25 18:00:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/12880007/22011
7 years, 9 months ago (2013-03-26 17:44:14 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-26 20:44:30 UTC) #6
Message was sent while issue was closed.
Change committed as 190756

Powered by Google App Engine
This is Rietveld 408576698