Source/platform/heap/Visitor.h - Issue 1287963002: Fix race at blink::GCInfoAtBase<T>::index

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/heap/Visitor.h

Issue 1287963002: Fix race at blink::GCInfoAtBase<T>::index (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@oilpan_1

Patch Set: Nits. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/heap/Visitor.h

diff --git a/Source/platform/heap/Visitor.h b/Source/platform/heap/Visitor.h

index 83b5f85b6d40556413df4d6011ba68f3b99c49ed..32dc5051cd92ff88286991c816612987ba177f9a 100644

--- a/Source/platform/heap/Visitor.h

+++ b/Source/platform/heap/Visitor.h

@@ -388,6 +388,7 @@ private:

template<typename T>

struct TypenameStringTrait {

+ // This method is not thread safe.

static const String& get()

{

DEFINE_STATIC_LOCAL(String, typenameString, (WTF::extractTypeNameFromFunctionName(WTF::extractNameFunction<T>())));

« no previous file with comments | « Source/platform/heap/GCInfo.h ('k') | no next file » | no next file with comments »