Upload Android test data to flakiness dashboard

Upload Android test data to flakiness dashboard

This CL adds flakiness dashboard integration to
android bots on chromium.linux.

BUG=150801
TEST=Verified flakiness arg passed for main waterfall bots but for trybots.
NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189516

[frankf, 2013-03-20 18:39:40]

https://codereview.chromium.org/12879017/diff/1/build/android/buildbot/bb_run...
File build/android/buildbot/bb_run_bot.py (right):

https://codereview.chromium.org/12879017/diff/1/build/android/buildbot/bb_run...
build/android/buildbot/bb_run_bot.py:149: extra_args.remove(flakiness_server)
I don't think all this logic is justified for removing one parameter. The
general way is to be able to inherit configurations (testers inherit from fyi +
some extra configuration). If that's too much for this CL, having a separate
configuration like before is simpler and more readable.

[Isaac (away), 2013-03-20 18:42:56]

https://codereview.chromium.org/12879017/diff/1/build/android/buildbot/bb_run...
File build/android/buildbot/bb_run_bot.py (right):

https://codereview.chromium.org/12879017/diff/1/build/android/buildbot/bb_run...
build/android/buildbot/bb_run_bot.py:149: extra_args.remove(flakiness_server)
On 2013/03/20 18:39:40, frankf wrote:
> I don't think all this logic is justified for removing one parameter. The
> general way is to be able to inherit configurations (testers inherit from fyi
+
> some extra configuration). If that's too much for this CL, having a separate
> configuration like before is simpler and more readable.

I'm not sure what you mean.  I'm open to other suggestions to how to do this but
I want to explicitly pin the trybot configurations to the main tester
configurations to make sure they don't diverge in the future.

[frankf, 2013-03-20 19:01:32]

lgtm

https://codereview.chromium.org/12879017/diff/1/build/android/buildbot/bb_run...
File build/android/buildbot/bb_run_bot.py (right):

https://codereview.chromium.org/12879017/diff/1/build/android/buildbot/bb_run...
build/android/buildbot/bb_run_bot.py:149: extra_args.remove(flakiness_server)
This is outside of the scope of this CL, but I think this is going to get
awkward if there's more divergence in the future. Just something to think about
is using inheritance instead of copying/removing things. As an example:

http://git.chromium.org/gitweb/?p=chromiumos/chromite.git;a=blob;f=buildbot/c...

On 2013/03/20 18:42:56, Isaac wrote:
> On 2013/03/20 18:39:40, frankf wrote:
> > I don't think all this logic is justified for removing one parameter. The
> > general way is to be able to inherit configurations (testers inherit from
fyi
> +
> > some extra configuration). If that's too much for this CL, having a separate
> > configuration like before is simpler and more readable.
> 
> I'm not sure what you mean.  I'm open to other suggestions to how to do this
but
> I want to explicitly pin the trybot configurations to the main tester
> configurations to make sure they don't diverge in the future.

[commit-bot: I haz the power, 2013-03-21 03:43:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ilevy@chromium.org/12879017/1

[commit-bot: I haz the power, 2013-03-21 03:53:25]

Change committed as 189516