Issue 12879016: Keep the obtained url patterns for notification settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12879016: Keep the obtained url patterns for notification settings. (Closed)

Created:
7 years, 9 months ago by Jun Mukai

Modified:
7 years, 9 months ago

Reviewers:
dharcourt, dewittj

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Keep the obtained url patterns for notification settings. The existing code re-creates a new content settings pattern from the URL, but it doesn't guarantee to create the exactly same settings pattern. Instead we should keep the original patterns and reuse it. BUG=222284 TEST=manually uncheck the url pattern from notification settings dialog Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189263

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -6 lines)			Patch
	M	chrome/browser/notifications/message_center_settings_controller.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
	M	chrome/browser/notifications/message_center_settings_controller.cc	View		4 chunks	+11 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/12879016/1

7 years, 9 months ago (2013-03-20 05:24:03 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/12879016/1

7 years, 9 months ago (2013-03-20 14:06:02 UTC) #4

Message was sent while issue was closed.

Change committed as 189263

Expand Messages | Collapse Messages