|
Removed task runners from the DesktopEnviroment interface and introduced ScreenControls/ClientSessionControl interfaces.
This CL removes all task runners that used to be passed to methods of DesktopEnviroment and DesktopEnviromentFactory interfaces. Instead each object implementing these interfaces receives the set of task runners it needs in the constructor. This change makes DesktopEnviroment and DesktopEnviromentFactory interfaces cleaner and easier to implement.
Added the ScreenControls interface used by the client session to change the screen resolution. Objects implementing ScreenControls are created by DesktopEnvironment::CreateScreenControls() method.
DesktopEnviromentFactory::Create() now receives a pointer to the ClientSessionControl interface providing a way to pause, resume, and disconnect the client session. It also receives notifications about the local mouse movements to temporarily block the remote input. The ClientSessionControl interface will be hooked up to the local impit monitor and the host UI once they will be moved to DesktopEnvironment.
BUG= 104544
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190345
Total comments: 10
Total comments: 18
Total comments: 6
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+624 lines, -566 lines) |
Patch |
|
M |
remoting/host/basic_desktop_environment.h
|
View
|
1
2
3
4
5
6
|
1 chunk |
+60 lines, -18 lines |
0 comments
|
Download
|
|
M |
remoting/host/basic_desktop_environment.cc
|
View
|
1
2
3
4
5
6
|
1 chunk |
+41 lines, -23 lines |
0 comments
|
Download
|
|
M |
remoting/host/chromoting_host.cc
|
View
|
1
2
3
4
5
6
|
5 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
remoting/host/chromoting_host_unittest.cc
|
View
|
1
2
3
4
5
6
|
2 chunks |
+7 lines, -19 lines |
0 comments
|
Download
|
|
M |
remoting/host/client_session.h
|
View
|
1
2
3
4
5
6
|
5 chunks |
+19 lines, -23 lines |
0 comments
|
Download
|
|
M |
remoting/host/client_session.cc
|
View
|
1
2
3
4
5
6
|
13 chunks |
+27 lines, -25 lines |
0 comments
|
Download
|
|
A |
remoting/host/client_session_control.h
|
View
|
1
2
3
4
|
1 chunk |
+40 lines, -0 lines |
0 comments
|
Download
|
|
M |
remoting/host/client_session_unittest.cc
|
View
|
1
2
3
4
5
6
|
4 chunks |
+11 lines, -27 lines |
0 comments
|
Download
|
|
M |
remoting/host/desktop_environment.h
|
View
|
1
2
3
4
5
6
|
4 chunks |
+11 lines, -15 lines |
0 comments
|
Download
|
|
M |
remoting/host/desktop_process.h
|
View
|
|
2 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
remoting/host/desktop_process.cc
|
View
|
|
5 chunks |
+7 lines, -6 lines |
0 comments
|
Download
|
|
M |
remoting/host/desktop_process_main.cc
|
View
|
|
2 chunks |
+16 lines, -2 lines |
0 comments
|
Download
|
|
M |
remoting/host/desktop_process_unittest.cc
|
View
|
1
2
3
4
5
6
|
4 chunks |
+8 lines, -21 lines |
0 comments
|
Download
|
|
M |
remoting/host/desktop_session_agent.h
|
View
|
1
2
3
4
5
6
|
8 chunks |
+20 lines, -11 lines |
0 comments
|
Download
|
|
M |
remoting/host/desktop_session_agent.cc
|
View
|
1
2
3
4
5
6
|
10 chunks |
+46 lines, -27 lines |
0 comments
|
Download
|
|
M |
remoting/host/desktop_session_proxy.h
|
View
|
1
2
3
4
5
6
|
3 chunks |
+12 lines, -18 lines |
0 comments
|
Download
|
|
M |
remoting/host/desktop_session_proxy.cc
|
View
|
1
2
3
4
5
6
|
6 chunks |
+29 lines, -26 lines |
0 comments
|
Download
|
|
M |
remoting/host/host_mock_objects.h
|
View
|
1
2
3
4
5
6
|
4 chunks |
+11 lines, -33 lines |
0 comments
|
Download
|
|
M |
remoting/host/host_mock_objects.cc
|
View
|
1
2
3
4
5
6
|
3 chunks |
+10 lines, -22 lines |
0 comments
|
Download
|
|
M |
remoting/host/ipc_desktop_environment.h
|
View
|
1
2
3
4
5
6
|
5 chunks |
+19 lines, -17 lines |
0 comments
|
Download
|
|
M |
remoting/host/ipc_desktop_environment.cc
|
View
|
1
2
3
4
5
6
|
3 chunks |
+35 lines, -41 lines |
0 comments
|
Download
|
|
M |
remoting/host/ipc_desktop_environment_unittest.cc
|
View
|
1
2
3
4
5
6
|
9 chunks |
+53 lines, -29 lines |
0 comments
|
Download
|
|
A + |
remoting/host/ipc_screen_controls.h
|
View
|
1
2
3
|
2 chunks |
+8 lines, -8 lines |
0 comments
|
Download
|
|
A + |
remoting/host/ipc_screen_controls.cc
|
View
|
1
2
3
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
remoting/host/ipc_session_controller.h
|
View
|
1
2
3
|
1 chunk |
+0 lines, -35 lines |
0 comments
|
Download
|
|
M |
remoting/host/ipc_session_controller.cc
|
View
|
1
2
3
|
1 chunk |
+0 lines, -25 lines |
0 comments
|
Download
|
|
M |
remoting/host/me2me_desktop_environment.h
|
View
|
1
2
3
4
|
2 chunks |
+12 lines, -8 lines |
0 comments
|
Download
|
|
M |
remoting/host/me2me_desktop_environment.cc
|
View
|
1
2
3
4
5
6
|
2 chunks |
+35 lines, -16 lines |
0 comments
|
Download
|
|
M |
remoting/host/plugin/host_script_object.cc
|
View
|
|
1 chunk |
+4 lines, -1 line |
0 comments
|
Download
|
|
M |
remoting/host/remoting_me2me_host.cc
|
View
|
1
2
3
4
5
6
|
1 chunk |
+9 lines, -1 line |
0 comments
|
Download
|
|
M |
remoting/host/resizing_host_observer.h
|
View
|
1
2
3
|
2 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
A + |
remoting/host/screen_controls.h
|
View
|
1
2
3
|
2 chunks |
+6 lines, -7 lines |
0 comments
|
Download
|
|
M |
remoting/host/session_controller.h
|
View
|
1
2
3
|
1 chunk |
+0 lines, -26 lines |
0 comments
|
Download
|
|
M |
remoting/host/win/session_desktop_environment.h
|
View
|
1
2
3
4
5
6
|
2 chunks |
+13 lines, -7 lines |
0 comments
|
Download
|
|
M |
remoting/host/win/session_desktop_environment.cc
|
View
|
1
2
3
4
5
6
|
1 chunk |
+33 lines, -12 lines |
0 comments
|
Download
|
|
M |
remoting/remoting.gyp
|
View
|
1
2
3
4
5
6
|
4 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
Total messages: 24 (0 generated)
|