Issue 12870010: Add device-level token entryption to CertLibrary.

Issue 12870010: Add device-level token entryption to CertLibrary. (Closed)

Created:
7 years, 9 months ago by David Roche

Modified:
7 years, 9 months ago

Reviewers:
xiyuan, zel

CC:
chromium-reviews, nkostylev+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add device-level token entryption to CertLibrary. BUG=164606 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188583

Patch Set 2 : Renamed methods per review comments. #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -45 lines)			Patch
M	chrome/browser/chromeos/app_mode/kiosk_app_launcher.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/cros/cert_library.h	View	1	1 chunk	+16 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/cros/cert_library.cc	View	1	7 chunks	+97 lines, -37 lines	0 comments	Download
M	chrome/browser/chromeos/cros/mock_cert_library.h	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

David Roche

Added encryption functions for device-level data using the system salt, as discussed. Xiyuan, if you're ...

7 years, 9 months ago (2013-03-14 19:57:03 UTC) #1

xiyuan

On 2013/03/14 19:57:03, David Roche wrote: > Added encryption functions for device-level data using the ...

7 years, 9 months ago (2013-03-14 20:20:11 UTC) #2

zel

https://codereview.chromium.org/12870010/diff/1/chrome/browser/chromeos/cros/cert_library.h File chrome/browser/chromeos/cros/cert_library.h (right): https://codereview.chromium.org/12870010/diff/1/chrome/browser/chromeos/cros/cert_library.h#newcode107 chrome/browser/chromeos/cros/cert_library.h:107: virtual std::string EncryptDeviceToken(const std::string& token) = 0; EncryptWithSystemSalt might ...

7 years, 9 months ago (2013-03-14 20:22:12 UTC) #3

David Roche

Thanks for the quick review! https://codereview.chromium.org/12870010/diff/1/chrome/browser/chromeos/cros/cert_library.h File chrome/browser/chromeos/cros/cert_library.h (right): https://codereview.chromium.org/12870010/diff/1/chrome/browser/chromeos/cros/cert_library.h#newcode107 chrome/browser/chromeos/cros/cert_library.h:107: virtual std::string EncryptDeviceToken(const std::string& ...

7 years, 9 months ago (2013-03-14 23:03:29 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidroche@chromium.org/12870010/6001

7 years, 9 months ago (2013-03-15 22:36:16 UTC) #6

Message was sent while issue was closed.

Change committed as 188583

Expand Messages | Collapse Messages