Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 12867003: Workaround gyp that removes duplicate arguments. (Closed)

Created:
7 years, 9 months ago by M-A Ruel
Modified:
7 years, 9 months ago
Reviewers:
csharp
CC:
chromium-reviews
Visibility:
Public.

Description

Workaround gyp that removes duplicate arguments. The slash will work fine even on Windows, since isolate.py reformats the path. NOTRY=true TBR=csharp@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188077

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M build/isolate.gypi View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
7 years, 9 months ago (2013-03-14 14:29:14 UTC) #1
csharp
Strange, but LGTM
7 years, 9 months ago (2013-03-14 14:30:31 UTC) #2
M-A Ruel
On 2013/03/14 14:30:31, csharp wrote: > Strange, but LGTM I had already been caught by ...
7 years, 9 months ago (2013-03-14 14:32:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/12867003/1
7 years, 9 months ago (2013-03-14 14:36:19 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-03-14 15:06:55 UTC) #5
Message was sent while issue was closed.
Change committed as 188077

Powered by Google App Engine
This is Rietveld 408576698