Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 12865019: Allow no-internal display mode (Closed)

Created:
7 years, 9 months ago by oshima
Modified:
7 years, 8 months ago
Reviewers:
Jun Mukai, Daniel Erat
CC:
chromium-reviews, stevenjb+watch_chromium.org, sadrul, oshima+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

Allow no-internal display mode - Remember primary per display pair - remember power state. Restore when restarted, but not boot time. - DefaultLayout is used to construct layout for display pair. It used to be used if the layout wasn't set before, but since layout has other data such as primary/mirror state, it makes more sense to copy it first. Cleanup: remove unnecessary code. BUG=218387 TEST=covered by test. manually tested on device. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191509

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 2

Patch Set 7 : #

Total comments: 5

Patch Set 8 : #

Total comments: 18

Patch Set 9 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+416 lines, -232 lines) Patch
M ash/ash.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M ash/display/display_controller.h View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
M ash/display/display_controller.cc View 1 2 3 4 5 6 7 16 chunks +74 lines, -59 lines 0 comments Download
M ash/display/display_controller_unittest.cc View 1 2 3 4 5 6 7 2 chunks +10 lines, -6 lines 0 comments Download
M ash/display/display_manager.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ash/display/display_manager.cc View 1 2 3 4 5 6 7 8 4 chunks +19 lines, -19 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 1 2 3 10 chunks +41 lines, -28 lines 0 comments Download
A ash/display/display_pref_util.h View 1 2 3 4 5 6 7 8 1 chunk +48 lines, -0 lines 0 comments Download
M ash/display/mouse_cursor_event_filter_unittest.cc View 1 2 12 chunks +25 lines, -25 lines 0 comments Download
M ash/display/screen_position_controller_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ash/extended_desktop_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ash/test/display_manager_test_api.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/display/display_preferences.h View 1 2 3 4 5 6 2 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/display/display_preferences.cc View 1 2 3 4 5 6 7 8 8 chunks +55 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/display/display_preferences_unittest.cc View 1 2 3 4 5 6 7 8 12 chunks +113 lines, -59 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/pref_names.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
M chromeos/display/output_configurator.h View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
oshima
i'm adding more test to display_preerence_unittests, but the rest is ready for review. PTL.
7 years, 9 months ago (2013-03-28 22:29:58 UTC) #1
oshima
On 2013/03/28 22:29:58, oshima wrote: > i'm adding more test to display_preerence_unittests, but > the ...
7 years, 9 months ago (2013-03-29 00:26:50 UTC) #2
Jun Mukai
https://codereview.chromium.org/12865019/diff/24001/ash/display/display_pref_util.h File ash/display/display_pref_util.h (right): https://codereview.chromium.org/12865019/diff/24001/ash/display/display_pref_util.h#newcode31 ash/display/display_pref_util.h:31: bool ReverseFind(const std::map<T, std::string>* map, can we add this ...
7 years, 9 months ago (2013-03-29 00:27:18 UTC) #3
oshima
https://codereview.chromium.org/12865019/diff/24001/ash/display/display_pref_util.h File ash/display/display_pref_util.h (right): https://codereview.chromium.org/12865019/diff/24001/ash/display/display_pref_util.h#newcode31 ash/display/display_pref_util.h:31: bool ReverseFind(const std::map<T, std::string>* map, On 2013/03/29 00:27:19, Jun ...
7 years, 9 months ago (2013-03-29 01:16:57 UTC) #4
Jun Mukai
lgtm https://codereview.chromium.org/12865019/diff/32001/chrome/browser/chromeos/display/display_preferences.cc File chrome/browser/chromeos/display/display_preferences.cc (right): https://codereview.chromium.org/12865019/diff/32001/chrome/browser/chromeos/display/display_preferences.cc#newcode261 chrome/browser/chromeos/display/display_preferences.cc:261: registry->RegisterInt64Pref(prefs::kPrimaryDisplayID, gfx::Display::kInvalidDisplayID); nit: exceeding 80 characters?
7 years, 9 months ago (2013-03-29 01:31:03 UTC) #5
oshima
https://codereview.chromium.org/12865019/diff/32001/chrome/browser/chromeos/display/display_preferences.cc File chrome/browser/chromeos/display/display_preferences.cc (right): https://codereview.chromium.org/12865019/diff/32001/chrome/browser/chromeos/display/display_preferences.cc#newcode261 chrome/browser/chromeos/display/display_preferences.cc:261: registry->RegisterInt64Pref(prefs::kPrimaryDisplayID, gfx::Display::kInvalidDisplayID); On 2013/03/29 01:31:03, Jun Mukai wrote: > ...
7 years, 9 months ago (2013-03-29 01:35:28 UTC) #6
oshima
Dan, please review.
7 years, 9 months ago (2013-03-29 01:35:59 UTC) #7
Daniel Erat
LGTM after some comments are addressed. I'll be out tomorrow, but if you check this ...
7 years, 9 months ago (2013-03-29 04:59:20 UTC) #8
oshima
https://codereview.chromium.org/12865019/diff/32001/ash/display/display_manager.cc File ash/display/display_manager.cc (right): https://codereview.chromium.org/12865019/diff/32001/ash/display/display_manager.cc#newcode306 ash/display/display_manager.cc:306: scoped_ptr<DisplayInfo> internal_display_info; On 2013/03/29 04:59:20, Daniel Erat wrote: > ...
7 years, 8 months ago (2013-03-29 17:01:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/12865019/45001
7 years, 8 months ago (2013-03-29 17:06:03 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=129319
7 years, 8 months ago (2013-03-30 02:01:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/12865019/45001
7 years, 8 months ago (2013-03-30 14:08:06 UTC) #12
commit-bot: I haz the power
7 years, 8 months ago (2013-03-30 16:09:51 UTC) #13
Message was sent while issue was closed.
Change committed as 191509

Powered by Google App Engine
This is Rietveld 408576698