Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 12859006: Add tests to capture traces of StartupTest.ProfilingScript1 with (Closed)

Created:
7 years, 9 months ago by ccameron
Modified:
7 years, 9 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Visibility:
Public.

Description

Add tests to capture traces of StartupTest.ProfilingScript1 with and without force-compositing-mode. Once I retrieve the traces from the bots, I'll revert this change. BUG=178497 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188327

Patch Set 1 #

Patch Set 2 : Conditionalize switch #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -1 line) Patch
M chrome/test/perf/startup_test.cc View 1 7 chunks +58 lines, -1 line 2 comments Download

Messages

Total messages: 5 (0 generated)
ccameron
I'll be using these new tests to harvest some data from the bots (and then ...
7 years, 9 months ago (2013-03-15 01:09:12 UTC) #1
Zhenyao Mo
LGTM since this is temporary https://codereview.chromium.org/12859006/diff/2001/chrome/test/perf/startup_test.cc File chrome/test/perf/startup_test.cc (right): https://codereview.chromium.org/12859006/diff/2001/chrome/test/perf/startup_test.cc#newcode89 chrome/test/perf/startup_test.cc:89: sleep(1); are you sure ...
7 years, 9 months ago (2013-03-15 02:51:47 UTC) #2
ccameron
Thanks!! https://codereview.chromium.org/12859006/diff/2001/chrome/test/perf/startup_test.cc File chrome/test/perf/startup_test.cc (right): https://codereview.chromium.org/12859006/diff/2001/chrome/test/perf/startup_test.cc#newcode89 chrome/test/perf/startup_test.cc:89: sleep(1); On 2013/03/15 02:51:47, Zhenyao Mo wrote: > ...
7 years, 9 months ago (2013-03-15 07:56:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/12859006/2001
7 years, 9 months ago (2013-03-15 07:58:19 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-03-15 10:46:14 UTC) #5
Message was sent while issue was closed.
Change committed as 188327

Powered by Google App Engine
This is Rietveld 408576698