Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 12859002: Use gold for ARM linux builds. (Closed)

Created:
7 years, 9 months ago by Sam Clegg
Modified:
7 years, 9 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Use gold for ARM linux builds. There is an issue using ld.bfd to cross build ARM chrome on linux (it seems to not honor --sysroot correctly) so make sure we use gold by default. BUG=191499 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188282

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +3 lines, -2 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Sam Clegg
7 years, 9 months ago (2013-03-14 01:24:16 UTC) #1
Lei Zhang
https://codereview.chromium.org/12859002/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/12859002/diff/1/build/common.gypi#newcode561 build/common.gypi:561: ['OS=="linux" and target_arch=="x64" and chromeos==0', { Do you care ...
7 years, 9 months ago (2013-03-14 02:03:30 UTC) #2
Sam Clegg
On 2013/03/14 02:03:30, Lei Zhang wrote: > https://codereview.chromium.org/12859002/diff/1/build/common.gypi > File build/common.gypi (right): > > https://codereview.chromium.org/12859002/diff/1/build/common.gypi#newcode561 ...
7 years, 9 months ago (2013-03-14 06:36:41 UTC) #3
Lei Zhang
lgtm
7 years, 9 months ago (2013-03-14 18:26:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/12859002/1
7 years, 9 months ago (2013-03-14 19:46:01 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-15 07:27:58 UTC) #6
Message was sent while issue was closed.
Change committed as 188282

Powered by Google App Engine
This is Rietveld 408576698