cc: Chromify animation_test_common

cc: Chromify animation_test_common

NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189681

[shawnsingh, 2013-03-20 22:46:23]

PTAL, thanks.

[danakj, 2013-03-20 23:16:36]

https://codereview.chromium.org/12854010/diff/3001/cc/test/animation_test_com...
File cc/test/animation_test_common.h (right):

https://codereview.chromium.org/12854010/diff/3001/cc/test/animation_test_com...
cc/test/animation_test_common.h:70: virtual void OnOpacityAnimated(float
FIXMENAME) OVERRIDE;
fixmenames

https://codereview.chromium.org/12854010/diff/3001/cc/test/animation_test_com...
cc/test/animation_test_common.h:82: int
AddOpacityTransitionToController(cc::LayerAnimationController& FIXMENAME,
and more

https://codereview.chromium.org/12854010/diff/3001/cc/test/animation_test_com...
cc/test/animation_test_common.h:87: int
AddAnimatedTransformToController(cc::LayerAnimationController& FIXMENAME,
also non-const ref's should be turned into pointers.

https://codereview.chromium.org/12854010/diff/3001/cc/test/animation_test_com...
cc/test/animation_test_common.h:92: int AddOpacityTransitionToLayer(cc::Layer&
FIXMENAME,
also no need for cc::

[shawnsingh, 2013-03-20 23:49:15]

PTAL at new patch, should be good to go =)

I also fixed a FIXMENAME that was found in nine patch layerImpl as a drive-by
here.

[danakj, 2013-03-20 23:58:11]

LGTM

https://codereview.chromium.org/12854010/diff/5003/cc/test/animation_test_com...
File cc/test/animation_test_common.cc (right):

https://codereview.chromium.org/12854010/diff/5003/cc/test/animation_test_com...
cc/test/animation_test_common.cc:27: int addOpacityTransition(Target* target,
AddOpacityTransition

https://codereview.chromium.org/12854010/diff/5003/cc/test/animation_test_com...
cc/test/animation_test_common.cc:58: int addAnimatedTransform(Target* target,
AddAnimatedTransform

[commit-bot: I haz the power, 2013-03-21 00:24:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shawnsingh@chromium.org/12854010/9002

[commit-bot: I haz the power, 2013-03-21 07:21:48]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-03-21 17:46:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shawnsingh@chromium.org/12854010/9002

[shawnsingh, 2013-03-21 20:08:02]

trybots did go far enough on the previous attempts to know it should be OK.  
For expedience, adding NOTRY to land this through cq again.

[commit-bot: I haz the power, 2013-03-21 20:08:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shawnsingh@chromium.org/12854010/25001

[commit-bot: I haz the power, 2013-03-21 20:12:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shawnsingh@chromium.org/12854010/25001

[commit-bot: I haz the power, 2013-03-21 20:12:51]

Change committed as 189681