Implement NativeAppWindowGtk::IsFullscreen.

Implement NativeAppWindowGtk::IsFullscreen.

Previously it always returned false.
This uses the same implementation as BrowserWindowGtk::IsFullscreen.

BUG=222513
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193345

[Elliot Glaysher, 2013-03-20 21:48:17]

I have not previously seen this class before.

Does this same pending trick need to happen in browser_window_gtk.cc? It's
implementation of IsFullscreen is: (state_ & GDK_WINDOW_STATE_FULLSCREEN);

[scheib, 2013-03-20 22:08:28]

IsFullscreenOrPending is a concept that was added to the FullscreenController
some time ago, and I think the main platform need was GTK which had an
asynchronous result. However, the detail of tracking if a request was already
made was kept higher level.

Perhaps IsFullscreen should respond 'true' when pending and we could drop
IsFullscreenOrPending. I'd prefer to leave that to another cleanup pass, though.
Just now I was starting work in NativeAppWindowGtk and didn't like that
IsFullscreen was being called but was hard coded false.

[scheib, 2013-03-20 22:08:52]

Re: first time you've seen it, I can move to another owner if you like.

[Elliot Glaysher, 2013-03-20 22:22:54]

You probably should. Maybe the extension people who wrote this?

[scheib, 2013-03-20 22:40:17]

estade, are you OK as reviewer for this?

[Evan Stade, 2013-03-25 22:12:18]

this is kind of weird in that WMs that don't support fullscreen will sometimes
report that they are fullscreen (until the next window state change operation).
I think that you need to check _NET_WM_ALLOWED_ACTIONS to see if the WM supports
fullscreen. I'm not sure on the details of how to do this.

[Evan Stade, 2013-03-25 22:12:50]

also, yes, BrowserWindowGtk's fullscreen mode is broken, and it's quite
annoying. Fixing that too would be sweet.

[scheib, 2013-04-09 17:59:27]

Fixing the check for entry to Fullscreen sounds like a fine idea, we can create
and prioritize an issue for it, but it is also out of the scope of getting
IsFullscreen returning the right value.

I've simplified this patch to use the same implementation as BrowserWindow.

[Evan Stade, 2013-04-10 04:24:38]

On 2013/04/09 17:59:27, scheib wrote:
> Fixing the check for entry to Fullscreen sounds like a fine idea, we can
create
> and prioritize an issue for it, but it is also out of the scope of getting
> IsFullscreen returning the right value.

can you file that bug please?

lgtm

[scheib, 2013-04-10 05:26:16]

Thanks. 

Issue filed: https://code.google.com/p/chromium/issues/detail?id=229768

[commit-bot: I haz the power, 2013-04-10 05:26:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scheib@chromium.org/12854008/12001

[commit-bot: I haz the power, 2013-04-10 08:31:15]

Change committed as 193345