Don't throw exceptions when v8 objects/contexts are missing, and catch

Don't throw exceptions when v8 objects/contexts are missing, and catch
exceptions that are thrown on GC. There is a path crashing the renderer:
v8 GC -> run extension function -> throws exception -> webkit tries to log ->
context has been GCed -> crash. Try to avoid that.


BUG=196581
R=mpcomplete@chromium.org
TBR=jhawkins@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188631

[Matt Perry, 2013-03-15 22:10:27]

LGTM with sadness

https://codereview.chromium.org/12853007/diff/2001/chrome/renderer/extensions...
File chrome/renderer/extensions/console.cc (right):

https://codereview.chromium.org/12853007/diff/2001/chrome/renderer/extensions...
chrome/renderer/extensions/console.cc:37: if
(helper->dispatcher()->v8_context_set().GetByV8Context(context_))
are helper and dispatcher guaranteed to be non-NULL?

https://codereview.chromium.org/12853007/diff/2001/chrome/renderer/extensions...
chrome/renderer/extensions/console.cc:117: LOG(WARNING) << "No render view found
for context";
nit: log the message here as well?

[not at google - send to devlin, 2013-03-15 22:19:49]

https://codereview.chromium.org/12853007/diff/2001/chrome/renderer/extensions...
File chrome/renderer/extensions/console.cc (right):

https://codereview.chromium.org/12853007/diff/2001/chrome/renderer/extensions...
chrome/renderer/extensions/console.cc:37: if
(helper->dispatcher()->v8_context_set().GetByV8Context(context_))
On 2013/03/15 22:10:27, Matt Perry wrote:
> are helper and dispatcher guaranteed to be non-NULL?

dispatcher yes, helper.. don't know, might as well be conservative.

https://codereview.chromium.org/12853007/diff/2001/chrome/renderer/extensions...
chrome/renderer/extensions/console.cc:117: LOG(WARNING) << "No render view found
for context";
On 2013/03/15 22:10:27, Matt Perry wrote:
> nit: log the message here as well?

Done.

https://codereview.chromium.org/12853007/diff/2001/chrome/renderer/extensions...
chrome/renderer/extensions/console.cc:117: LOG(WARNING) << "No render view found
for context";
On 2013/03/15 22:10:27, Matt Perry wrote:
> nit: log the message here as well?

Done.

[commit-bot: I haz the power, 2013-03-15 22:22:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/12853007/10001

[commit-bot: I haz the power, 2013-03-16 00:06:56]

Failed to trigger a try job on win_x64_rel
HTTP Error 400: Bad Request

[commit-bot: I haz the power, 2013-03-16 00:07:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/12853007/20001

[commit-bot: I haz the power, 2013-03-16 01:16:13]

Failed to trigger a try job on mac
HTTP Error 400: Bad Request

[commit-bot: I haz the power, 2013-03-16 01:16:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/12853007/31001

[commit-bot: I haz the power, 2013-03-16 04:17:53]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-03-17 01:24:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/12853007/39002

[commit-bot: I haz the power, 2013-03-17 02:37:42]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-03-17 03:20:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/12853007/61001

[commit-bot: I haz the power, 2013-03-17 09:26:02]

Change committed as 188631