Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: chrome/browser/password_manager/password_store_win_unittest.cc

Issue 12853004: Move creation of WebDatabaseTable subclasses to WebDatabaseServiceFactory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix merge error. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_store_win_unittest.cc
diff --git a/chrome/browser/password_manager/password_store_win_unittest.cc b/chrome/browser/password_manager/password_store_win_unittest.cc
index ce0b50ab1f855aff4bed7ea099db47c64f5dea9b..587beb5aeca9f55a9d0e4e59eaf49e866f6671f1 100644
--- a/chrome/browser/password_manager/password_store_win_unittest.cc
+++ b/chrome/browser/password_manager/password_store_win_unittest.cc
@@ -20,6 +20,7 @@
#include "chrome/browser/password_manager/password_form_data.h"
#include "chrome/browser/password_manager/password_store_consumer.h"
#include "chrome/browser/password_manager/password_store_win.h"
+#include "chrome/browser/webdata/logins_table.h"
#include "chrome/browser/webdata/web_data_service.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/testing_profile.h"
@@ -114,9 +115,12 @@ class PasswordStoreWinTest : public testing::Test {
login_db_.reset(new LoginDatabase());
ASSERT_TRUE(login_db_->Init(temp_dir_.path().Append(
FILE_PATH_LITERAL("login_test"))));
- wds_ = new WebDataService(WebDataServiceBase::ProfileErrorCallback());
base::FilePath path = temp_dir_.path().AppendASCII("web_data_test");
- wds_->Init(path);
+ wds_ = new WebDataService(path,
+ WebDataServiceBase::ProfileErrorCallback());
+ // Need to add at least one table so the database gets created.
+ wds_->AddTable(scoped_ptr<WebDatabaseTable>(new LoginsTable()));
+ wds_->Init();
}
virtual void TearDown() {
« no previous file with comments | « chrome/browser/api/webdata/web_data_service_base.h ('k') | chrome/browser/webdata/autofill_web_data_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698