Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1285103005: Update targetSdkVersion to 23. (Closed)

Created:
5 years, 4 months ago by aurimas (slooooooooow)
Modified:
5 years, 4 months ago
CC:
android-webview-reviews_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, jbudorick+watch_chromium.org, jochen+watch_chromium.org, klundberg+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, samuong+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update targetSdkVersion to 23. We moved to Android SDK 23. This CL updates the targetSdkVersion to match the SDK. See behavior changes here: http://developer.android.com/preview/api-overview.html BUG=522182 TBR=yfriedman@chromium.org Committed: https://crrev.com/3b59fc6a0927e3d5f24321125270065f4d3fbf72 Cr-Commit-Position: refs/heads/master@{#344942}

Patch Set 1 #

Patch Set 2 : Updated WebView targetSdk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M android_webview/apk/java/AndroidManifest.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/test/shell/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/tools/WebViewShell/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M build/android/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/shell/java/AndroidManifest.xml.jinja2 View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/shell/javatests/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/sync_shell/java/AndroidManifest.xml.jinja2 View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/sync_shell/javatests/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/android/unit_tests_apk/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/test/webview_shell/java/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/sample/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/sample/javatests/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/test/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/test/javaperftests/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/test/javatests/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M components/test/android/browsertests_apk/AndroidManifest.xml.jinja2 View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/browsertests_apk/AndroidManifest.xml.jinja2 View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/javatests/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/linker_test_apk/AndroidManifest.xml.jinja2 View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/shell_apk/AndroidManifest.xml.jinja2 View 1 chunk +1 line, -1 line 0 comments Download
M net/android/unittest_support/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M testing/android/driver/java/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M testing/android/native_test/java/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (3 generated)
aurimas (slooooooooow)
boliu: android_webview/* jbudorick: build/android/* dfalcantara: chrome/android/*, chrome/test/android/* samuong: chrome/test/chromedriver/* mmenke: components/cronet/*, net/* sievers: components/test/android/* yfriedman: ...
5 years, 4 months ago (2015-08-20 18:21:48 UTC) #2
jbudorick
lgtm
5 years, 4 months ago (2015-08-20 18:22:47 UTC) #3
samuong
lgtm
5 years, 4 months ago (2015-08-20 18:24:26 UTC) #4
mmenke
On 2015/08/20 18:21:48, aurimas wrote: > boliu: android_webview/* > jbudorick: build/android/* > dfalcantara: chrome/android/*, chrome/test/android/* ...
5 years, 4 months ago (2015-08-20 18:24:30 UTC) #5
gone
lgtm
5 years, 4 months ago (2015-08-20 18:25:19 UTC) #6
boliu
can you update android_webview/apk/java/AndroidManifest.xml as well, make the default targetSdkVersion be 23 as well chrome/android/java/AndroidManifest.xml ...
5 years, 4 months ago (2015-08-20 18:34:48 UTC) #7
aurimas (slooooooooow)
On 2015/08/20 at 18:34:48, boliu wrote: > can you update android_webview/apk/java/AndroidManifest.xml as well, make the ...
5 years, 4 months ago (2015-08-20 18:41:05 UTC) #8
boliu
android_webview lgtm
5 years, 4 months ago (2015-08-20 18:42:03 UTC) #9
no sievers
lgtm
5 years, 4 months ago (2015-08-20 19:26:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285103005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285103005/20001
5 years, 4 months ago (2015-08-22 00:15:07 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-22 00:46:26 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-22 00:47:30 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3b59fc6a0927e3d5f24321125270065f4d3fbf72
Cr-Commit-Position: refs/heads/master@{#344942}

Powered by Google App Engine
This is Rietveld 408576698