Remove ConstrainedWindowGtkDelegate

Remove ConstrainedWindowGtkDelegate

Part 3/5 of the Gtk ContstrainedWindow API rework towards removing
ConstrainedWindowGtk in favor of using a native Widget.

Use "destroy" signal to destroy web contents modal dialog contents
classes, rather than explicit requests from ConstrainedWindowGtk.
Remove ConstrainedWindowGtkDelegate.


BUG=157161
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188325

[Elliot Glaysher, 2013-03-13 23:48:10]

https://codereview.chromium.org/12851002/diff/1/chrome/browser/ui/gtk/constra...
File chrome/browser/ui/gtk/constrained_web_dialog_delegate_gtk.cc (right):

https://codereview.chromium.org/12851002/diff/1/chrome/browser/ui/gtk/constra...
chrome/browser/ui/gtk/constrained_web_dialog_delegate_gtk.cc:125: void
SetBackgroundColor(GtkWidget* widget, const GdkColor &color) {
This should go in the existing anonymous namespace at the top of the file.

https://codereview.chromium.org/12851002/diff/1/chrome/browser/ui/gtk/tab_con...
File chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.h
(right):

https://codereview.chromium.org/12851002/diff/1/chrome/browser/ui/gtk/tab_con...
chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.h:60:
ui::ScopedGObject<GtkWidget>::Type floating_;
This makes me slightly nervous. Why are you changing the scoping type?
OnwedWidgetGtk has a lots of DCHECKs to make sure its used correctly and I don't
remember encountering a ScopedGObject in our code...

[Mike Wittman, 2013-03-14 00:34:48]

https://codereview.chromium.org/12851002/diff/1/chrome/browser/ui/gtk/constra...
File chrome/browser/ui/gtk/constrained_web_dialog_delegate_gtk.cc (right):

https://codereview.chromium.org/12851002/diff/1/chrome/browser/ui/gtk/constra...
chrome/browser/ui/gtk/constrained_web_dialog_delegate_gtk.cc:125: void
SetBackgroundColor(GtkWidget* widget, const GdkColor &color) {
On 2013/03/13 23:48:10, Elliot Glaysher wrote:
> This should go in the existing anonymous namespace at the top of the file.

Done.

https://codereview.chromium.org/12851002/diff/1/chrome/browser/ui/gtk/tab_con...
File chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.h
(right):

https://codereview.chromium.org/12851002/diff/1/chrome/browser/ui/gtk/tab_con...
chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.h:60:
ui::ScopedGObject<GtkWidget>::Type floating_;
On 2013/03/13 23:48:10, Elliot Glaysher wrote:
> This makes me slightly nervous. Why are you changing the scoping type?
> OnwedWidgetGtk has a lots of DCHECKs to make sure its used correctly and I
don't
> remember encountering a ScopedGObject in our code...

OwnedWidgetGtk requires that it be the last entity holding a reference on the
object (it DCHECKs reference count == 1 in its destructor).  With the change to
destroy dialogs based on the "destroy" signal, not all the other references to
the floating container are released by the time ChromeWebContentsViewDelegateGtk
is destroyed.

[Elliot Glaysher, 2013-03-14 17:16:30]

lgtm

[commit-bot: I haz the power, 2013-03-15 00:47:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wittman@chromium.org/12851002/6001

[commit-bot: I haz the power, 2013-03-15 10:45:36]

Change committed as 188325