Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 12850007: [Android] Exclude findbugs false-positives in the javabridge. (Closed)

Created:
7 years, 9 months ago by Yaron
Modified:
7 years, 9 months ago
Reviewers:
joth
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

[Android] Exclude findbugs false-positives in the javabridge. Findbugs can't trace the reflection code which is accessing these methods/members. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188749

Patch Set 1 #

Patch Set 2 : rebaes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -43 lines) Patch
M build/android/findbugs_filter/findbugs_exclude.xml View 1 chunk +5 lines, -0 lines 0 comments Download
M build/android/findbugs_filter/findbugs_known_bugs.txt View 3 chunks +0 lines, -43 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Yaron
7 years, 9 months ago (2013-03-15 19:18:16 UTC) #1
Steve Block
LGTM The bot seems unhappy, but perhaps that's just a transient due to you changing ...
7 years, 9 months ago (2013-03-17 23:05:06 UTC) #2
Yaron
On 2013/03/17 23:05:06, Steve Block wrote: > LGTM > > The bot seems unhappy, but ...
7 years, 9 months ago (2013-03-18 15:46:13 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 9 months ago (2013-03-18 15:59:36 UTC) #4
Yaron
joth: can you stamp?
7 years, 9 months ago (2013-03-18 16:03:48 UTC) #5
joth
lgtm
7 years, 9 months ago (2013-03-18 16:15:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/12850007/5001
7 years, 9 months ago (2013-03-18 16:15:19 UTC) #7
commit-bot: I haz the power
7 years, 9 months ago (2013-03-18 16:15:31 UTC) #8
Message was sent while issue was closed.
Change committed as 188749

Powered by Google App Engine
This is Rietveld 408576698