Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 12847010: Fix leaks introduced by WDS change (Closed)

Created:
7 years, 9 months ago by Cait (Slow)
Modified:
7 years, 9 months ago
Reviewers:
Jói
CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman
Visibility:
Public.

Description

Fix leaks introduced by WDS change Make sure tests give WDS time to shutdown its DB. TBR=atwilson@chromium.org (for Signin changes) R=joi@chromium.org BUG=222363 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189388

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M chrome/browser/signin/token_service_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/autofill/browser/personal_data_manager_unittest.cc View 1 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Jói
This LGTM, with a nit about a comment, as long as my assumption below is ...
7 years, 9 months ago (2013-03-20 16:18:42 UTC) #1
Cait (Slow)
https://codereview.chromium.org/12847010/diff/1/components/autofill/browser/personal_data_manager_unittest.cc File components/autofill/browser/personal_data_manager_unittest.cc (right): https://codereview.chromium.org/12847010/diff/1/components/autofill/browser/personal_data_manager_unittest.cc#newcode82 components/autofill/browser/personal_data_manager_unittest.cc:82: base::WaitableEvent done(false, false); On 2013/03/20 16:18:42, Jói wrote: > ...
7 years, 9 months ago (2013-03-20 16:49:02 UTC) #2
Jói
LGTM
7 years, 9 months ago (2013-03-20 16:50:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/12847010/6001
7 years, 9 months ago (2013-03-20 17:02:18 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-03-20 20:32:08 UTC) #5
Message was sent while issue was closed.
Change committed as 189388

Powered by Google App Engine
This is Rietveld 408576698