Make LazyMultiError only constructable via function

common/errors/multierror_test.go

Index: common/errors/multierror_test.go
diff --git a/common/errors/multierror_test.go b/common/errors/multierror_test.go
index a7a15329e1f430accde5798033af90a1a3d0b129..1bb7b0896297cbe60e4debc19964e552d28881b1 100644
--- a/common/errors/multierror_test.go
+++ b/common/errors/multierror_test.go
@@ -6,7 +6,6 @@ package errors
 
 import (
 	"errors"
-	"sync"
 	"testing"
 
 	. "github.com/smartystreets/goconvey/convey"
@@ -60,79 +59,3 @@ func TestUpstreamErrors(t *testing.T) {
 		So(Fix(e), ShouldEqual, e)
 	})
 }
-
-func TestLazyMultiError(t *testing.T) {
-	t.Parallel()
-
-	Convey("Test LazyMultiError", t, func() {
-		lme := LazyMultiError{Size: 10}
-		So(lme.Get(), ShouldEqual, nil)
-
-		e := errors.New("sup")
-		lme.Assign(6, e)
-		So(lme.Get(), ShouldResemble,
-			MultiError{nil, nil, nil, nil, nil, nil, e, nil, nil, nil})
-
-		lme.Assign(2, e)
-		So(lme.Get(), ShouldResemble,
-			MultiError{nil, nil, e, nil, nil, nil, e, nil, nil, nil})
-
-		So(func() { lme.Assign(20, e) }, ShouldPanic)
-
-		Convey("Try to freak out the race detector", func() {
-			lme := LazyMultiError{Size: 64}
-			Convey("all nils", func() {
-				wg := sync.WaitGroup{}
-				for i := 0; i < 64; i++ {
-					wg.Add(1)
-					go func(i int) {
-						lme.Assign(i, nil)
-						wg.Done()
-					}(i)
-				}
-				wg.Wait()
-				So(lme.Get(), ShouldBeNil)
-			})
-			Convey("every other", func() {
-				wow := errors.New("wow")
-				wg := sync.WaitGroup{}
-				for i := 0; i < 64; i++ {
-					wg.Add(1)
-					go func(i int) {
-						e := error(nil)
-						if i&1 == 1 {
-							e = wow
-						}
-						lme.Assign(i, e)
-						wg.Done()
-					}(i)
-				}
-				wg.Wait()
-				me := make(MultiError, 64)
-				for i := range me {
-					if i&1 == 1 {
-						me[i] = wow
-					}
-				}
-				So(lme.Get(), ShouldResemble, me)
-			})
-			Convey("all", func() {
-				wow := errors.New("wow")
-				wg := sync.WaitGroup{}
-				for i := 0; i < 64; i++ {
-					wg.Add(1)
-					go func(i int) {
-						lme.Assign(i, wow)
-						wg.Done()
-					}(i)
-				}
-				wg.Wait()
-				me := make(MultiError, 64)
-				for i := range me {
-					me[i] = wow
-				}
-				So(lme.Get(), ShouldResemble, me)
-			})
-		})
-	})
-}