Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 12837013: [Telemetry] Don't crash if a process is stopped between GetChildPids() and GetMemoryStats() or GetI… (Closed)

Created:
7 years, 9 months ago by tonyg
Modified:
7 years, 9 months ago
Reviewers:
dtu, nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] Don't crash if a process is stopped between GetChildPids() and GetMemoryStats() or GetIOStats(). Example of this crash on the bots: http://build.chromium.org/p/chromium.perf/builders/Win7%20Perf%20%281%29/builds/8028/steps/indexeddb/logs/stdio BUG=None TEST=indexed_db page cycler on windows NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190535

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M tools/telemetry/telemetry/core/chrome/win_platform_backend.py View 2 chunks +18 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tonyg
ptal
7 years, 9 months ago (2013-03-25 23:48:34 UTC) #1
dtu
lgtm
7 years, 9 months ago (2013-03-26 00:21:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/12837013/1
7 years, 9 months ago (2013-03-26 00:43:16 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-26 01:00:59 UTC) #4
Message was sent while issue was closed.
Change committed as 190535

Powered by Google App Engine
This is Rietveld 408576698