Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 12836005: Always mark the entire valid prefix of the descriptor array. (Closed)

Created:
7 years, 9 months ago by Toon Verwaest
Modified:
7 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Always mark the entire valid prefix of the descriptor array. Previously we would only mark the slot that was added specifically for this map, if there was a backpointer and the descriptor array was shared via the backpointer. However, ConvertTransitionToMapTransition may break this link after we marked the transitioned map, before we marked the transitioning map. So the descriptor slots of the parent map won't get recorded, and we potentially point to an old address of an already relocated function. BUG=chromium:196331 Committed: https://code.google.com/p/v8/source/detail?r=14027

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M src/objects-visiting-inl.h View 1 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL
7 years, 9 months ago (2013-03-21 10:46:43 UTC) #1
Michael Starzinger
LGTM with a nit. https://chromiumcodereview.appspot.com/12836005/diff/1/src/objects-visiting-inl.h File src/objects-visiting-inl.h (right): https://chromiumcodereview.appspot.com/12836005/diff/1/src/objects-visiting-inl.h#newcode400 src/objects-visiting-inl.h:400: // descriptors that appeared for ...
7 years, 9 months ago (2013-03-21 12:15:36 UTC) #2
Toon Verwaest
Addressed comment
7 years, 9 months ago (2013-03-21 12:19:09 UTC) #3
Toon Verwaest
7 years, 9 months ago (2013-03-21 12:19:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r14027 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698