Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12833002: Adds strings for the iOS net-export error dialog. (Closed)

Created:
7 years, 9 months ago by rohitrao (ping after 24h)
Modified:
7 years, 9 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Adds strings for the iOS net-export error dialog. BUG=None TEST=No visible impact. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188079

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : CQ #

Patch Set 4 : CQ? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M build/ios/grit_whitelist.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
rohitrao (ping after 24h)
Does this look reasonable? Do we need to do anything special when landing strings that ...
7 years, 9 months ago (2013-03-13 13:24:36 UTC) #1
stuartmorgan
LGTM Upstreaming strings first is fine, and there's no special handling. It creates an odd ...
7 years, 9 months ago (2013-03-13 13:36:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rohitrao@chromium.org/12833002/1
7 years, 9 months ago (2013-03-13 15:05:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rohitrao@chromium.org/12833002/1
7 years, 9 months ago (2013-03-13 19:06:48 UTC) #4
commit-bot: I haz the power
Failed to trigger a try job on linux_chromeos HTTP Error 400: Bad Request
7 years, 9 months ago (2013-03-13 19:07:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rohitrao@chromium.org/12833002/24001
7 years, 9 months ago (2013-03-13 19:14:34 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 9 months ago (2013-03-13 21:32:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rohitrao@chromium.org/12833002/24001
7 years, 9 months ago (2013-03-13 21:42:57 UTC) #8
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 9 months ago (2013-03-13 23:01:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rohitrao@chromium.org/12833002/60001
7 years, 9 months ago (2013-03-14 02:11:37 UTC) #10
commit-bot: I haz the power
7 years, 9 months ago (2013-03-14 15:20:34 UTC) #11
Message was sent while issue was closed. 
Change committed as 188079

Powered by Google App Engine
This is Rietveld 408576698