src/x64/lithium-x64.cc - Issue 12832002: Parallel recompilation: fewer handle dereferences and tighter checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-x64.cc

Issue 12832002: Parallel recompilation: fewer handle dereferences and tighter checks. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/lithium-x64.cc

diff --git a/src/x64/lithium-x64.cc b/src/x64/lithium-x64.cc

index 25cc823be229225215c39ca859bb5d0a53718ddf..394637cf3da6e46d6d587245240c62cf28c4ade0 100644

--- a/src/x64/lithium-x64.cc

+++ b/src/x64/lithium-x64.cc

@@ -945,7 +945,7 @@ LInstruction* LChunkBuilder::DoBranch(HBranch* instr) {

if (value->EmitAtUses()) {

ASSERT(value->IsConstant());

ASSERT(!value->representation().IsDouble());

- HBasicBlock* successor = HConstant::cast(value)->ToBoolean()

+ HBasicBlock* successor = HConstant::cast(value)->BooleanValue()

? instr->FirstSuccessor()

: instr->SecondSuccessor();

return new(zone()) LGoto(successor->block_id());

« no previous file with comments | « src/v8.cc ('k') | no next file » | no next file with comments »