Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: src/code-stubs-hydrogen.cc

Issue 12832002: Parallel recompilation: fewer handle dereferences and tighter checks. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/compiler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 21 matching lines...) Expand all
32 #include "lithium.h" 32 #include "lithium.h"
33 33
34 namespace v8 { 34 namespace v8 {
35 namespace internal { 35 namespace internal {
36 36
37 37
38 static LChunk* OptimizeGraph(HGraph* graph) { 38 static LChunk* OptimizeGraph(HGraph* graph) {
39 Isolate* isolate = graph->isolate(); 39 Isolate* isolate = graph->isolate();
40 AssertNoAllocation no_gc; 40 AssertNoAllocation no_gc;
41 NoHandleAllocation no_handles(isolate); 41 NoHandleAllocation no_handles(isolate);
42 NoHandleDereference no_deref(isolate); 42 HandleDereferenceGuard no_deref(isolate, HandleDereferenceGuard::DISALLOW);
43 43
44 ASSERT(graph != NULL); 44 ASSERT(graph != NULL);
45 SmartArrayPointer<char> bailout_reason; 45 SmartArrayPointer<char> bailout_reason;
46 if (!graph->Optimize(&bailout_reason)) { 46 if (!graph->Optimize(&bailout_reason)) {
47 FATAL(bailout_reason.is_empty() ? "unknown" : *bailout_reason); 47 FATAL(bailout_reason.is_empty() ? "unknown" : *bailout_reason);
48 } 48 }
49 LChunk* chunk = LChunk::NewChunk(graph); 49 LChunk* chunk = LChunk::NewChunk(graph);
50 if (chunk == NULL) { 50 if (chunk == NULL) {
51 FATAL(graph->info()->bailout_reason()); 51 FATAL(graph->info()->bailout_reason());
52 } 52 }
(...skipping 322 matching lines...) Expand 10 before | Expand all | Expand 10 after
375 } 375 }
376 376
377 377
378 Handle<Code> ArrayNArgumentsConstructorStub::GenerateCode() { 378 Handle<Code> ArrayNArgumentsConstructorStub::GenerateCode() {
379 CodeStubGraphBuilder<ArrayNArgumentsConstructorStub> builder(this); 379 CodeStubGraphBuilder<ArrayNArgumentsConstructorStub> builder(this);
380 LChunk* chunk = OptimizeGraph(builder.CreateGraph()); 380 LChunk* chunk = OptimizeGraph(builder.CreateGraph());
381 return chunk->Codegen(Code::COMPILED_STUB); 381 return chunk->Codegen(Code::COMPILED_STUB);
382 } 382 }
383 383
384 } } // namespace v8::internal 384 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698