Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 12827002: Prepare push to trunk. Now working on version 3.17.11. (Closed)

Created:
7 years, 9 months ago by ulan
Modified:
7 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Prepare push to trunk. Now working on version 3.17.11. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=13920

Patch Set 1 #

Total comments: 10

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M ChangeLog View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ulan
7 years, 9 months ago (2013-03-13 09:25:01 UTC) #1
Jakob Kummerow
LGTM with comments. https://chromiumcodereview.appspot.com/12827002/diff/1/ChangeLog File ChangeLog (right): https://chromiumcodereview.appspot.com/12827002/diff/1/ChangeLog#newcode3 ChangeLog:3: Renamed android_build_type to android_webview_build. You can ...
7 years, 9 months ago (2013-03-13 09:27:53 UTC) #2
ulan
Thanks, landing. https://chromiumcodereview.appspot.com/12827002/diff/1/ChangeLog File ChangeLog (right): https://chromiumcodereview.appspot.com/12827002/diff/1/ChangeLog#newcode3 ChangeLog:3: Renamed android_build_type to android_webview_build. On 2013/03/13 09:27:53, ...
7 years, 9 months ago (2013-03-13 09:29:57 UTC) #3
ulan
7 years, 9 months ago (2013-03-13 09:30:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r13920 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698