Chromium Code Reviews

Issue 1282063003: Allow intent picker for external schemes (Closed)

Created:
5 years, 4 months ago by Ian Wen
Modified:
5 years, 4 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, ianwen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow intent picker for external schemes For urls that chrome can handle, a custom tab will not fire the intent picker. Yet for urls with heterogeneous schemes, chrome cannot load anyway. In this case, we should show an intent picker, in stead of doing nothing. BUG=513522 Committed: https://crrev.com/dbb85091f6afe3bed62267f264d4acfdf81ea68c Cr-Commit-Position: refs/heads/master@{#342924}

Patch Set 1 #

Total comments: 4

Patch Set 2 : respond to comments #

Patch Set 3 : #

Unified diffs Side-by-side diffs Stats (+10 lines, -12 lines)
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java View 2 chunks +10 lines, -12 lines 0 comments

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
Ian Wen
ptal. We should merge this CL to M45 as it impacts our revenue.
5 years, 4 months ago (2015-08-07 22:26:13 UTC) #2
Yusuf
lgtm with a few style nits. https://codereview.chromium.org/1282063003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java File chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java (right): https://codereview.chromium.org/1282063003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java#newcode257 chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java:257: if (haveDefaultHandler(intent) || ...
5 years, 4 months ago (2015-08-10 05:37:16 UTC) #3
Ian Wen
https://codereview.chromium.org/1282063003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java File chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java (right): https://codereview.chromium.org/1282063003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java#newcode257 chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java:257: if (haveDefaultHandler(intent) || isExternalProtocol) { On 2015/08/10 05:37:15, Yusuf ...
5 years, 4 months ago (2015-08-11 21:42:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282063003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282063003/40001
5 years, 4 months ago (2015-08-11 21:43:12 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-11 22:52:15 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 22:52:51 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dbb85091f6afe3bed62267f264d4acfdf81ea68c
Cr-Commit-Position: refs/heads/master@{#342924}

Powered by Google App Engine