Allow encoded version of service=chromiumsync

Allow encoded version of service=chromiumsync


BUG=188688
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188313

[Roger Tawa OOO till Jul 10th, 2013-03-14 19:11:03]

lgtm with nit below.

https://codereview.chromium.org/12817005/diff/1/chrome/browser/signin/signin_...
File chrome/browser/signin/signin_manager.cc (right):

https://codereview.chromium.org/12817005/diff/1/chrome/browser/signin/signin_...
chrome/browser/signin/signin_manager.cc:93:
url.query().find(kChromiumSyncService2) != std::string::npos;
I think it would be better to do something like:

  return UnescapeURLComponent(
      url.query(), UnescapeRule::URL_SPECIAL_CHARS)
          .find(kChromiumSyncService);

from "net/base/escape.h".

[bcwhite, 2013-03-14 19:22:36]

https://codereview.chromium.org/12817005/diff/1/chrome/browser/signin/signin_...
File chrome/browser/signin/signin_manager.cc (right):

https://codereview.chromium.org/12817005/diff/1/chrome/browser/signin/signin_...
chrome/browser/signin/signin_manager.cc:93:
url.query().find(kChromiumSyncService2) != std::string::npos;
On 2013/03/14 19:11:03, Roger Tawa wrote:
> I think it would be better to do something like:
> 
>   return UnescapeURLComponent(
>       url.query(), UnescapeRule::URL_SPECIAL_CHARS)
>           .find(kChromiumSyncService);
> 
> from "net/base/escape.h".

Done.

[commit-bot: I haz the power, 2013-03-14 20:13:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bcwhite@chromium.org/12817005/7001

[commit-bot: I haz the power, 2013-03-15 09:13:42]

Change committed as 188313