Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1121)

Issue 12813004: Chromium style checker cleanup (Closed)

Created:
7 years, 9 months ago by Ryan Sleevi
Modified:
7 years, 9 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, dhollowa+watch_chromium.org, amit, ahutter, browser-components-watch_chromium.org, dcheng, rginda+watch_chromium.org, Albert Bodenhamer, stevenjb+watch_chromium.org, sergeyu+watch_chromium.org, yusukes+watch_chromium.org, dcaiafa+watch_chromium.org, cbentzel+watch_chromium.org, ben+watch_chromium.org, benquan, Ilya Sherman, jam, dbeam+watch-autofill_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, tim (not reviewing), jennb, jonathan.backer, wez+watch_chromium.org, Raghu Simha, gspencer+watch_chromium.org, sanjeevr, gauravsh+watch_chromium.org, jianli, simonmorris+watch_chromium.org, feature-media-reviews_chromium.org, rmsousa+watch_chromium.org, oshima+watch_chromium.org, Raman Kakilate, haitaol1, alexeypa+watch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, akalin, Ian Vollick, tfarina, Dmitry Titov, garykac+watch_chromium.org, Aaron Boodman, lambroslambrou+watch_chromium.org, Dane Wallinga, dyu1, piman+watch_chromium.org, estade+watch_chromium.org, cc-bugs_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Chromium style checker cleanup Automated clean up of style checker errors that were missed due to the plugin not being executed on implementation files. BUG=115047 TBR=ben, brettw, jamesr, joi, satorux, piman, wez Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188311

Patch Set 1 #

Patch Set 2 : Rebased to ToT #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -89 lines) Patch
M ash/shelf/shelf_widget.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M cc/layer_tree_host_unittest_delegated.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/picture_layer_impl_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_picture_layer_tiling_client.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/worker_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_external_delegate_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_configuration_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_canary_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_crash_recovery_browsertest.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/history/delete_directive_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/notification_browsertest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_service.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/invalidations/invalidator_storage_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_command_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/base_panel_browser_test.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/page_launcher/page_launcher_manifest_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handler_unittest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/renderer/benchmarking_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/net_benchmarking_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/printer_job_handler_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/service/cloud_print/printer_job_queue_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/session_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/onc/onc_merger.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/autofill/browser/autocomplete_history_manager_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/image_transport_factory.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/web_contents_video_capture_device_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/context_provider_command_buffer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/accessibility/renderer_accessibility_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gpu_tracer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/congestion_control/leaky_bucket_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/crypto_framer.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M net/quic/quic_crypto_client_stream_test.cc View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_framer_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/simple_quic_framer.cc View 1 2 3 chunks +16 lines, -15 lines 0 comments Download
M remoting/host/resizing_host_observer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/compositor.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download
M ui/message_center/views/message_center_bubble.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/gpu/context_provider_in_process.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Ryan Sleevi
This is a giant TBR of mechanical changes, all of which I've previously sent to ...
7 years, 9 months ago (2013-03-14 14:22:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/12813004/1
7 years, 9 months ago (2013-03-14 14:28:46 UTC) #2
commit-bot: I haz the power
Failed to apply patch for cc/layer_tree_host_unittest_delegated.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 9 months ago (2013-03-14 14:29:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/12813004/5001
7 years, 9 months ago (2013-03-14 14:40:58 UTC) #4
jamesr
lgtm
7 years, 9 months ago (2013-03-14 16:18:34 UTC) #5
Jói
LGTM for //components
7 years, 9 months ago (2013-03-14 16:34:50 UTC) #6
alexeypa (please no reviews)
lgtm - remoting/*
7 years, 9 months ago (2013-03-14 16:36:31 UTC) #7
brettw
lgtm
7 years, 9 months ago (2013-03-14 17:40:09 UTC) #8
piman
lgtm
7 years, 9 months ago (2013-03-14 17:52:26 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, chrome_frame_net_tests, chrome_frame_tests, chrome_frame_unittests, content_browsertests, installer_util_unittests, ...
7 years, 9 months ago (2013-03-14 19:54:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/12813004/27001
7 years, 9 months ago (2013-03-14 19:54:27 UTC) #11
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests, content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=19958
7 years, 9 months ago (2013-03-14 20:51:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/12813004/27001
7 years, 9 months ago (2013-03-14 20:57:45 UTC) #13
commit-bot: I haz the power
7 years, 9 months ago (2013-03-15 09:12:53 UTC) #14
Message was sent while issue was closed.
Change committed as 188311

Powered by Google App Engine
This is Rietveld 408576698