Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 12811012: Eliminate CopyResultsFromXxxCallback defined in drive_resource_metadata_unittest.cc (Closed)

Created:
7 years, 9 months ago by hidehiko
Modified:
7 years, 9 months ago
Reviewers:
hashimoto, kinaba
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Eliminate CopyResultsFromXxxCallback defined in drive_resource_metadata_unittest.cc Replace the methods with CreateCopyResultCallback. BUG=180569 TEST=Ran unit_tests --gtest_filter=DriveResourceMetadata* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190488

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -27 lines) Patch
M chrome/browser/chromeos/drive/drive_resource_metadata_unittest.cc View 1 4 chunks +13 lines, -27 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hidehiko
Thank you for your review in advance, - hidehiko
7 years, 9 months ago (2013-03-21 14:45:03 UTC) #1
kinaba
lgtm
7 years, 9 months ago (2013-03-21 14:56:36 UTC) #2
hashimoto
lgtm
7 years, 9 months ago (2013-03-21 15:27:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12811012/5001
7 years, 9 months ago (2013-03-25 17:04:25 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-03-25 21:53:31 UTC) #5
Message was sent while issue was closed.
Change committed as 190488

Powered by Google App Engine
This is Rietveld 408576698