Save the GIT hash of HEAD when uploading to rietveld.

Save the GIT hash of HEAD when uploading to rietveld.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=188807

[M-A Ruel, 2013-03-14 13:28:27]

https://codereview.chromium.org/12811006/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/12811006/diff/1/git_cl.py#newcode103
git_cl.py:103: def git_set_branch_value_str(key, value):
I prefer one function.

cmd = ['config']
if isinstance(value, int):
  cmd.append('--int')
value = str(value)

https://codereview.chromium.org/12811006/diff/1/git_cl.py#newcode1299
git_cl.py:1299: if ret == 0:
if not ret

[Roger Tawa OOO till Jul 10th, 2013-03-14 19:49:42]

Thanks MA.  Changes uploaded.

https://codereview.chromium.org/12811006/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/12811006/diff/1/git_cl.py#newcode103
git_cl.py:103: def git_set_branch_value_str(key, value):
On 2013/03/14 13:28:27, Marc-Antoine Ruel wrote:
> I prefer one function.
> 
> cmd = ['config']
> if isinstance(value, int):
>   cmd.append('--int')
> value = str(value)

Done.

https://codereview.chromium.org/12811006/diff/1/git_cl.py#newcode1299
git_cl.py:1299: if ret == 0:
On 2013/03/14 13:28:27, Marc-Antoine Ruel wrote:
> if not ret

Done.

[Roger Tawa OOO till Jul 10th, 2013-03-15 14:19:17]

Salut MA,

Fixed up tests.  Please have a look.  Thanks.

[M-A Ruel, 2013-03-17 19:40:31]

lgtm

https://codereview.chromium.org/12811006/diff/6001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/12811006/diff/6001/git_cl.py#newcode98
git_cl.py:98: if branch:
I think I'd prefer this form instead;

if not branch:
  return

[Roger Tawa OOO till Jul 10th, 2013-03-18 20:40:28]

Thanks MA.

https://codereview.chromium.org/12811006/diff/6001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/12811006/diff/6001/git_cl.py#newcode98
git_cl.py:98: if branch:
On 2013/03/17 19:40:31, Marc-Antoine Ruel wrote:
> I think I'd prefer this form instead;
> 
> if not branch:
>   return

Done.

[commit-bot: I haz the power, 2013-03-18 20:42:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rogerta@chromium.org/12811006/11001

[commit-bot: I haz the power, 2013-03-18 20:45:07]

Change committed as 188807