Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: test/mjsunit/regress/readonly4.js

Issue 12810006: Change LookupForWrite to always do a full lookup and check the result. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/mjsunit/regress/readonly3.js ('k') | test/mjsunit/regress/setter.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 #include "v8.h" 28 var slow = {};
29 var p = {};
29 30
30 #include "cctest.h" 31 slow.__proto__ = p;
32 slow.x = 10;
33 slow.y = 10;
34 Object.defineProperty(p, "x", {writable:false, value:5});
31 35
32 using namespace v8; 36 function c(p) {
37 return {__proto__: p};
38 }
33 39
34 // This test fails if properties on the prototype of the global object appear 40 function s(v) {
35 // as declared globals. 41 return v.x = 1;
36 TEST(StrictUndeclaredGlobalVariable) {
37 HandleScope scope(Isolate::GetCurrent());
38 v8::Local<v8::String> var_name = v8_str("x");
39 LocalContext context;
40 v8::TryCatch try_catch;
41 v8::Local<v8::Script> script = v8_compile("\"use strict\"; x = 42;");
42 v8::Handle<v8::Object> proto = v8::Object::New();
43 v8::Handle<v8::Object> global =
44 context->Global()->GetPrototype().As<v8::Object>();
45 proto->Set(var_name, v8_num(100));
46 global->SetPrototype(proto);
47 script->Run();
48 CHECK(try_catch.HasCaught());
49 v8::String::Utf8Value exception(try_catch.Exception());
50 CHECK_EQ("ReferenceError: x is not defined", *exception);
51 } 42 }
43
44 function s_strict(v) {
45 "use strict";
46 v.x = 1;
47 }
48
49 var o1 = c(slow);
50 var o2 = c(slow);
51 var o1_strict = c(slow);
52 var o2_strict = c(slow);
53 var o3 = c(slow);
54 var o4 = c(slow);
55
56 // Make s slow.
57 // Do this after using slow as prototype, since using an object as prototype
58 // kicks it back into fast mode.
59 delete slow.y;
60
61 s(o1);
62 s(o2);
63 s_strict(o1_strict);
64 s_strict(o2_strict);
65
66 delete slow.x;
67 // Directly setting x should fail.
68 o3.x = 20
69 assertEquals(5, o3.x);
70
71 // Setting x through IC should fail.
72 s(o4);
73 assertEquals(5, o4.x);
74 assertThrows("s_strict(o4);", TypeError);
OLDNEW
« no previous file with comments | « test/mjsunit/regress/readonly3.js ('k') | test/mjsunit/regress/setter.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698