Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Side by Side Diff: src/property.h

Issue 12810006: Change LookupForWrite to always do a full lookup and check the result. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ic.cc ('k') | src/stub-cache.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 344 matching lines...) Expand 10 before | Expand all | Expand 10 after
355 case HANDLER: 355 case HANDLER:
356 case INTERCEPTOR: 356 case INTERCEPTOR:
357 case TRANSITION: 357 case TRANSITION:
358 case NONEXISTENT: 358 case NONEXISTENT:
359 return isolate()->heap()->the_hole_value(); 359 return isolate()->heap()->the_hole_value();
360 } 360 }
361 UNREACHABLE(); 361 UNREACHABLE();
362 return NULL; 362 return NULL;
363 } 363 }
364 364
365 Map* GetTransitionTarget(Map* map) {
366 ASSERT(IsTransition());
367 TransitionArray* transitions = map->transitions();
368 return transitions->GetTarget(number_);
369 }
370
365 Map* GetTransitionTarget() { 371 Map* GetTransitionTarget() {
366 ASSERT(IsTransition()); 372 return GetTransitionTarget(holder()->map());
367 TransitionArray* transitions = holder()->map()->transitions();
368 return transitions->GetTarget(number_);
369 } 373 }
370 374
371 PropertyDetails GetTransitionDetails(Map* map) { 375 PropertyDetails GetTransitionDetails(Map* map) {
372 ASSERT(IsTransition()); 376 ASSERT(IsTransition());
373 TransitionArray* transitions = map->transitions(); 377 TransitionArray* transitions = map->transitions();
374 return transitions->GetTargetDetails(number_); 378 return transitions->GetTargetDetails(number_);
375 } 379 }
376 380
377 PropertyDetails GetTransitionDetails() { 381 PropertyDetails GetTransitionDetails() {
378 return GetTransitionDetails(holder()->map()); 382 return GetTransitionDetails(holder()->map());
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
473 JSReceiver* holder_; 477 JSReceiver* holder_;
474 int number_; 478 int number_;
475 bool cacheable_; 479 bool cacheable_;
476 PropertyDetails details_; 480 PropertyDetails details_;
477 }; 481 };
478 482
479 483
480 } } // namespace v8::internal 484 } } // namespace v8::internal
481 485
482 #endif // V8_PROPERTY_H_ 486 #endif // V8_PROPERTY_H_
OLDNEW
« no previous file with comments | « src/ic.cc ('k') | src/stub-cache.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698