Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issue 12803011: Add BaseWindow::GetContentBounds() and use in WindowController::CreateWindowValue() (Closed)

Created:
7 years, 9 months ago by stevenjb
Modified:
7 years, 8 months ago
Reviewers:
CC:
chromium-reviews, jennb, tfarina, jianli, Dmitry Titov, dcheng, Aaron Boodman, sail+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Add BaseWindow::GetContentBounds() and use in WindowController::CreateWindowValue() chrome.windows.create() width and height creation parameters correspond to the inner (content) bounds. The properties set in WindowController::CreateWindowValue() should match this. BUG=173831

Patch Set 1 #

Patch Set 2 : Add test files #

Patch Set 3 : Fix osx and gtk builds #

Patch Set 4 : Fix osx build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -13 lines) Patch
M chrome/browser/extensions/window_controller.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/extensions/window_open_apitest.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/base_window.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/native_app_window_cocoa.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/native_app_window_cocoa.mm View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/native_app_window_gtk.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/native_app_window_gtk.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/extensions/native_app_window_views.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/extensions/native_app_window_views.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/test_browser_window.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/api_test/window_open/window_size/manifest.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/test/data/extensions/api_test/window_open/window_size/popup.html View 1 1 chunk +5 lines, -2 lines 0 comments Download
A + chrome/test/data/extensions/api_test/window_open/window_size/test.html View 1 2 1 chunk +1 line, -4 lines 0 comments Download
A chrome/test/data/extensions/api_test/window_open/window_size/test.js View 1 1 chunk +17 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698