Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: remoting/base/rate_counter_unittest.cc

Issue 12803008: Add unit tests for sub-components of CaptureScheduler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/base/rate_counter_unittest.cc
diff --git a/remoting/base/rate_counter_unittest.cc b/remoting/base/rate_counter_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..03b7ea847cdfc2eb799e7096cb7762e34f9b2a51
--- /dev/null
+++ b/remoting/base/rate_counter_unittest.cc
@@ -0,0 +1,83 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "remoting/base/rate_counter.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace remoting {
+
+static const int64 kTestValues[] = { 10, 20, 30, 10, 25, 16, 15 };
+
+// One second window and one sample per second, so rate equals each sample.
+TEST(RateCounterTest, OneSecondWindow) {
+ RateCounter rate_counter(base::TimeDelta::FromSeconds(1));
+ EXPECT_EQ(0, rate_counter.Rate());
+
+ base::Time now = base::Time::Now();
+ for (size_t i = 0; i < arraysize(kTestValues); ++i) {
+ now += base::TimeDelta::FromSeconds(1);
+ rate_counter.SetCurrentTimeForTest(now);
+ rate_counter.Record(kTestValues[i]);
+ EXPECT_EQ(static_cast<double>(kTestValues[i]), rate_counter.Rate());
+ }
+}
+
+// Record all samples instantaneously, so the rate is the total of the samples.
+TEST(RateCounterTest, OneSecondWindowAllSamples) {
+ RateCounter rate_counter(base::TimeDelta::FromSeconds(1));
+ EXPECT_EQ(0, rate_counter.Rate());
+
+ rate_counter.SetCurrentTimeForTest(base::Time::Now());
+
+ double expected = 0.0;
+ for (size_t i = 0; i < arraysize(kTestValues); ++i) {
+ rate_counter.Record(kTestValues[i]);
+ expected += kTestValues[i];
+ }
+
+ EXPECT_EQ(expected, rate_counter.Rate());
+}
+
+// Two second window, one sample per second. For all but the first sample, the
+// rate should be the average of it and the preceding one. For the first it
+// will be the average of the sample with zero.
+TEST(RateCounterTest, TwoSecondWindow) {
+ RateCounter rate_counter(base::TimeDelta::FromSeconds(2));
+ EXPECT_EQ(0, rate_counter.Rate());
+
+ base::Time now = base::Time::Now();
+ for (size_t i = 0; i < arraysize(kTestValues); ++i) {
+ now += base::TimeDelta::FromSeconds(1);
+ rate_counter.SetCurrentTimeForTest(now);
+ rate_counter.Record(kTestValues[i]);
+ double expected = kTestValues[i];
+ if (i > 0)
+ expected += kTestValues[i-1];
+ expected /= 2;
+ EXPECT_EQ(expected, rate_counter.Rate());
+ }
+}
+
+// Sample over a window one second shorter than the number of samples.
+// Rate should be the average of all but the first sample.
+TEST(RateCounterTest, LongWindow) {
+ const size_t kWindowSeconds = arraysize(kTestValues) - 1;
+
+ RateCounter rate_counter(base::TimeDelta::FromSeconds(kWindowSeconds));
+ EXPECT_EQ(0, rate_counter.Rate());
+
+ double expected = 0.0;
+ base::Time now = base::Time::Now();
+ for (size_t i = 1; i < arraysize(kTestValues); ++i) {
alexeypa (please no reviews) 2013/03/19 23:36:55 nit: I guess kTestValues[0] should also be recorde
Wez 2013/03/20 00:17:27 Done.
+ now += base::TimeDelta::FromSeconds(1);
+ rate_counter.SetCurrentTimeForTest(now);
+ rate_counter.Record(kTestValues[i]);
+ expected += kTestValues[i];
+ }
+ expected /= kWindowSeconds;
+
+ EXPECT_EQ(expected, rate_counter.Rate());
+}
+
+} // namespace remoting

Powered by Google App Engine
This is Rietveld 408576698