lib/protobuf_field.dart - Issue 128003003: Fix issue with importing packages where the package name included a dot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/protobuf_field.dart

Issue 128003003: Fix issue with importing packages where the package name included a dot (Closed) Base URL: https://github.com/dart-lang/dart-protoc-plugin.git@master

Patch Set: Update pubspec version Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/protobuf_field.dart

diff --git a/lib/protobuf_field.dart b/lib/protobuf_field.dart

index bb2f6cc49d21b7001f61085fc271042eba2a9b79..fb0d564115260bc7c6d3f9e643a6e537e0a9974d 100644

--- a/lib/protobuf_field.dart

+++ b/lib/protobuf_field.dart

@@ -267,7 +267,7 @@ class ProtobufField {

typePackage = groupType.package;

baseType = groupType.classname;

typeString = write(groupType.classname);

- prefixedBaseType = groupType.package + '.' + baseType;

+ prefixedBaseType = groupType.packageImportPrefix + '.' + baseType;

prefixedTypeString = write(prefixedBaseType);

codedStreamType = 'Group';

} else {

@@ -282,7 +282,7 @@ class ProtobufField {

typePackage = messageType.package;

baseType = messageType.classname;

typeString = write(baseType);

- prefixedBaseType = messageType.package + '.' + baseType;

+ prefixedBaseType = messageType.packageImportPrefix + '.' + baseType;

prefixedTypeString = write(prefixedBaseType);

codedStreamType = 'Message';

} else {

@@ -298,7 +298,7 @@ class ProtobufField {

baseType = enumType.classname;

typeString = write(enumType.classname);

codedStreamType = 'Enum';

- prefixedBaseType = enumType.package + '.' + baseType;

+ prefixedBaseType = enumType.packageImportPrefix + '.' + baseType;

prefixedTypeString = write(prefixedBaseType);

packable = true;

if (!repeats) {

« no previous file with comments | « lib/message_generator.dart ('k') | pubspec.yaml » ('j') | no next file with comments »