Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 12796009: Remove suppressions related to App Notifications (Closed)

Created:
7 years, 9 months ago by rlarocque
Modified:
7 years, 9 months ago
Reviewers:
dcheng
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Remove suppressions related to App Notifications Most of the app notifications code was removed in r187201, but some suppressions were left behind. This commit removes suppressions for functions that no longer exist. BUG=136297, 99166, 115197, 149712 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189179

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -35 lines) Patch
M tools/code_coverage/coverage_posix.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/heapcheck/suppressions.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M tools/heapcheck/unit_tests.gtest-heapcheck.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/valgrind/drmemory/suppressions_full.txt View 1 chunk +0 lines, -9 lines 0 comments Download
M tools/valgrind/gtest_exclude/browser_tests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -1 line 0 comments Download
M tools/valgrind/gtest_exclude/unit_tests.gtest.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rlarocque
Please review.
7 years, 9 months ago (2013-03-15 23:32:37 UTC) #1
dcheng
lgtm
7 years, 9 months ago (2013-03-19 18:35:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/12796009/1
7 years, 9 months ago (2013-03-19 18:55:38 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-20 00:46:47 UTC) #4
Message was sent while issue was closed.
Change committed as 189179

Powered by Google App Engine
This is Rietveld 408576698