Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1389)

Unified Diff: content/ppapi_plugin/ppapi_thread.cc

Issue 12793004: [Mac] Do not unload base::NativeLibary-ies if they contain ObjC segments. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: The never ending review! Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/native_library_mac.mm ('K') | « base/native_library_mac.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/ppapi_plugin/ppapi_thread.cc
diff --git a/content/ppapi_plugin/ppapi_thread.cc b/content/ppapi_plugin/ppapi_thread.cc
index f2245f4f5b5a017858884bc1ca3fa3a443d35acf..6aa7b809b81cf93e685646cd9584945f0d25483b 100644
--- a/content/ppapi_plugin/ppapi_thread.cc
+++ b/content/ppapi_plugin/ppapi_thread.cc
@@ -117,16 +117,6 @@ PpapiThread::~PpapiThread() {
plugin_entry_points_.shutdown_module();
WebKit::shutdown();
-#if defined(OS_MACOSX)
- // TODO(shess): <http://crbug.com/172319> is about how modules
- // cannot be unloaded when Objective-C is involved. interaction
- // between the Objective-C runtime and module unloading. Leaking
- // the module here to work around this, a later CL should autodetect
- // the problem and leak in NativeLibrary.
- if (is_broker_)
- library_.Release();
-#endif
-
#if defined(OS_WIN)
if (permissions_.HasPermission(ppapi::PERMISSION_FLASH))
base::win::SetShouldCrashOnProcessDetach(false);
« base/native_library_mac.mm ('K') | « base/native_library_mac.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698