Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issue 12792008: Remove some ant macros (Closed)

Created:
7 years, 9 months ago by cjhopman
Modified:
7 years, 9 months ago
Reviewers:
shashi, Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@delete_cruft3
Visibility:
Public.

Description

Remove some ant macros We only use this build script for non-library targets with code... so remove the macros for do-only-if-library/has-code. The other macros are used only in a single place, so inline them at that use. BUG=158821 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188101

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -226 lines) Patch
M build/android/ant/apk-build.xml View 7 chunks +128 lines, -226 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
cjhopman
7 years, 9 months ago (2013-03-12 23:54:47 UTC) #1
Yaron
lgtm
7 years, 9 months ago (2013-03-13 00:37:05 UTC) #2
shashi
lgtm, make sure to verify resources for clobber as well as incremental builds for this ...
7 years, 9 months ago (2013-03-13 01:21:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/12792008/5001
7 years, 9 months ago (2013-03-14 01:05:35 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 9 months ago (2013-03-14 16:09:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/12792008/5001
7 years, 9 months ago (2013-03-14 16:33:04 UTC) #6
commit-bot: I haz the power
7 years, 9 months ago (2013-03-14 16:46:53 UTC) #7
Message was sent while issue was closed.
Change committed as 188101

Powered by Google App Engine
This is Rietveld 408576698