chrome/common/extensions/api/extension_api.cc - Issue 12792005: Allow extensions on chrome:// URLs, when flag is set and permission is explicitly requested

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/extension_api.cc

Issue 12792005: Allow extensions on chrome:// URLs, when flag is set and permission is explicitly requested (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Reinstate original pickle order; add scripts clause to content_script_chrome_url_invalid.json to av… Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/api/extension_api.cc

diff --git a/chrome/common/extensions/api/extension_api.cc b/chrome/common/extensions/api/extension_api.cc

index 87dd20a5f02f6d72550558dad3d5db41c4d9a092..c9988e55859afcf51739c3027444ac6cf5aab99c 100644

--- a/chrome/common/extensions/api/extension_api.cc

+++ b/chrome/common/extensions/api/extension_api.cc

@@ -271,7 +271,7 @@ void ExtensionAPI::LoadSchema(const std::string& name,

std::string pattern;

CHECK(matches->GetString(i, &pattern));

pattern_set.AddPattern(

- URLPattern(UserScript::kValidUserScriptSchemes, pattern));

+ URLPattern(UserScript::ValidUserScriptSchemes(), pattern));

}

url_matching_apis_[schema_namespace] = pattern_set;

}

« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »