Issue 12790007: Fix File Copy Manager Wrapper to work in the strict mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12790007: Fix File Copy Manager Wrapper to work in the strict mode. (Closed)

Created:
7 years, 9 months ago by mtomasz

Modified:
7 years, 9 months ago

Reviewers:
yoshiki

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix File Copy Manager Wrapper to work in the strict mode. After enabling strict mode, butter bar stopped working, since wrapper became not accessible from the backgroudn copy manager. This patch solves this issue by converting a global variable to a class member and exporting the class. NOTRY=true TEST=Copying should display the butter bar. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189585

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -8 lines)			Patch
M	chrome/browser/resources/file_manager/js/file_copy_manager.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_copy_manager_wrapper.js	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/main_scripts.js	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12790007/1

7 years, 9 months ago (2013-03-21 07:46:14 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12790007/1

7 years, 9 months ago (2013-03-21 12:46:53 UTC) #5

Message was sent while issue was closed.

Change committed as 189585

Expand Messages | Collapse Messages