Issue 12790003: Remove more unused ant stuff

Issue 12790003: Remove more unused ant stuff (Closed)

Created:
7 years, 9 months ago by cjhopman

Modified:
7 years, 9 months ago

Reviewers:
shashi, Yaron

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@delete_cruft5

Visibility:
Public.

More Reviews

Description

Remove more unused ant stuff Remove/inline some more properties that are not used. Remove the clean target that we never call. Remove some comments that are incorrect or invalid in our build. BUG=158821 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188186

Patch Set 1 #

Total comments: 3

Patch Set 2 : rebase #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -116 lines)			Patch
	M	build/android/ant/apk-build.xml	View		13 chunks	+24 lines, -116 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

shashi

https://codereview.chromium.org/12790003/diff/1/build/android/ant/apk-build.xml File build/android/ant/apk-build.xml (left): https://codereview.chromium.org/12790003/diff/1/build/android/ant/apk-build.xml#oldcode392 build/android/ant/apk-build.xml:392: fork="${need.javac.fork}" nit: can probably also eliminate need.javac.fork by setting ...

7 years, 9 months ago (2013-03-13 02:08:25 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/12790003/4001

7 years, 9 months ago (2013-03-14 19:45:05 UTC) #5

Message was sent while issue was closed.

Change committed as 188186

Expand Messages | Collapse Messages