Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1278403007: [tracing] Fix accounting of WebCache memory statistics (Closed)

Created:
5 years, 4 months ago by ssid
Modified:
5 years, 4 months ago
Reviewers:
dcheng
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@oilpan_light
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[tracing] Fix accounting of WebCache memory statistics The 'other' field was not added to the memory stats returned by blink WebCache. This CL fixes this issue, and also adds purged and purgeable size to the stats. This will be used for memory-infra as a part of chrome://tracing: see crrev.com/1283793004. BUG=466141 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200404

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changing internal api to use size_t. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -12 lines) Patch
M Source/core/fetch/MemoryCache.h View 1 1 chunk +8 lines, -8 lines 0 comments Download
M Source/web/WebCache.cpp View 1 2 chunks +7 lines, -4 lines 0 comments Download
M public/web/WebCache.h View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (2 generated)
ssid
PTAL. See https://codereview.chromium.org/1283793004/diff/60001/components/web_cache/renderer/web_cache_memory_dump_provider.cc for the use case. Thanks
5 years, 4 months ago (2015-08-11 20:37:33 UTC) #2
dcheng
https://codereview.chromium.org/1278403007/diff/1/Source/web/WebCache.cpp File Source/web/WebCache.cpp (right): https://codereview.chromium.org/1278403007/diff/1/Source/web/WebCache.cpp#newcode48 Source/web/WebCache.cpp:48: to.purgedSize = static_cast<size_t>(from.purgedSize); How come the core types don't ...
5 years, 4 months ago (2015-08-12 00:24:14 UTC) #3
ssid
Thanks PTAL. https://codereview.chromium.org/1278403007/diff/1/Source/web/WebCache.cpp File Source/web/WebCache.cpp (right): https://codereview.chromium.org/1278403007/diff/1/Source/web/WebCache.cpp#newcode48 Source/web/WebCache.cpp:48: to.purgedSize = static_cast<size_t>(from.purgedSize); On 2015/08/12 00:24:14, dcheng ...
5 years, 4 months ago (2015-08-12 11:21:03 UTC) #4
dcheng
lgtm
5 years, 4 months ago (2015-08-12 17:01:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278403007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278403007/20001
5 years, 4 months ago (2015-08-12 17:01:57 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 17:08:17 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200404

Powered by Google App Engine
This is Rietveld 408576698