Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issue 12782019: Move browser_components_metrics.py into a subdirectory of tools/metrics/ (Closed)

Created:
7 years, 9 months ago by Ilya Sherman
Modified:
7 years, 8 months ago
Reviewers:
Jói
CC:
chromium-reviews, sail+watch_chromium.org, tfarina
Visibility:
Public.

Description

Move //tools/metrics into //components/ directory. BUG=223859 R=joi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192443

Patch Set 1 #

Patch Set 2 : Move files to //compontents/tools/metrics #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, -200 lines) Patch
A + components/tools/metrics/browser_components_metrics.py View 1 2 chunks +3 lines, -2 lines 0 comments Download
A + components/tools/metrics/count_ifdefs.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/tools/metrics/count_ifdefs_unittest.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/tools/metrics/testdata/foo.cc View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/tools/metrics/testdata/foo_ignored.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/tools/metrics/testdata/subdir/foo_test.mm View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/metrics/browser_components_metrics.py View 1 chunk +0 lines, -64 lines 0 comments Download
D tools/metrics/count_ifdefs.py View 1 chunk +0 lines, -77 lines 0 comments Download
D tools/metrics/count_ifdefs_unittest.py View 1 chunk +0 lines, -30 lines 0 comments Download
D tools/metrics/testdata/foo.cc View 1 chunk +0 lines, -20 lines 0 comments Download
D tools/metrics/testdata/foo_ignored.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D tools/metrics/testdata/subdir/foo_test.mm View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Ilya Sherman
Jói, are these files still used? I tried running the script in a clean branch, ...
7 years, 9 months ago (2013-03-26 07:45:12 UTC) #1
tfarina
On 2013/03/26 07:45:12, Ilya Sherman wrote: > Jói, are these files still used? Yeah, I'd ...
7 years, 9 months ago (2013-03-27 13:21:58 UTC) #2
Ilya Sherman
On 2013/03/27 13:21:58, tfarina wrote: > On 2013/03/26 07:45:12, Ilya Sherman wrote: > > I ...
7 years, 9 months ago (2013-03-28 00:13:37 UTC) #3
Jói
//components/tools/metrics SGTM. On Thu, Mar 28, 2013 at 12:13 AM, <isherman@chromium.org> wrote: > On 2013/03/27 ...
7 years, 8 months ago (2013-04-03 14:00:38 UTC) #4
Ilya Sherman
On 2013/04/03 14:00:38, Jói wrote: > //components/tools/metrics SGTM. Done.
7 years, 8 months ago (2013-04-04 05:33:23 UTC) #5
Jói
LGTM, thanks.
7 years, 8 months ago (2013-04-04 09:59:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/12782019/5001
7 years, 8 months ago (2013-04-04 10:20:32 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=130967
7 years, 8 months ago (2013-04-04 13:15:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/12782019/5001
7 years, 8 months ago (2013-04-04 21:57:21 UTC) #9
commit-bot: I haz the power
7 years, 8 months ago (2013-04-05 02:05:22 UTC) #10
Message was sent while issue was closed.
Change committed as 192443

Powered by Google App Engine
This is Rietveld 408576698