Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 12781011: [MIPS] Implement register_set.{c,h} parts for MIPS (Closed)

Created:
7 years, 9 months ago by petarj
Modified:
7 years, 9 months ago
Reviewers:
Mark Seaborn
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/src/native_client.git@master
Visibility:
Public.

Description

[MIPS] Implement register_set.{c,h} parts for MIPS Implementation of macros used in register_set files when arch is MIPS. BUG= https://code.google.com/p/nativeclient/issues/detail?id=2275 TEST= run register_set test Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=10973

Patch Set 1 #

Total comments: 4

Patch Set 2 : Nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -0 lines) Patch
M tests/common/register_set.h View 1 4 chunks +111 lines, -0 lines 0 comments Download
M tests/common/register_set.c View 5 chunks +80 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
petarj
Second subset of changes from https://codereview.chromium.org/12256018/ Only register_set.c and register_set.h There was a question about ...
7 years, 9 months ago (2013-03-12 22:40:07 UTC) #1
Mark Seaborn
LGTM, thanks https://codereview.chromium.org/12781011/diff/1/tests/common/register_set.h File tests/common/register_set.h (right): https://codereview.chromium.org/12781011/diff/1/tests/common/register_set.h#newcode384 tests/common/register_set.h:384: /* We skip setting k0 and k1 ...
7 years, 9 months ago (2013-03-12 23:07:28 UTC) #2
petarj
https://codereview.chromium.org/12781011/diff/1/tests/common/register_set.h File tests/common/register_set.h (right): https://codereview.chromium.org/12781011/diff/1/tests/common/register_set.h#newcode384 tests/common/register_set.h:384: /* We skip setting k0 and k1 registers, they ...
7 years, 9 months ago (2013-03-12 23:44:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/12781011/31001
7 years, 9 months ago (2013-03-12 23:44:29 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-03-13 02:30:47 UTC) #5
Message was sent while issue was closed.
Change committed as 10973

Powered by Google App Engine
This is Rietveld 408576698