Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: tools/run-bisect-perf-regression.py

Issue 12780015: Added call to stop goma in case it's still running from a build that timed out. Added --verbose par… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/prepare-bisect-perf-regression.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/run-bisect-perf-regression.py
diff --git a/tools/run-bisect-perf-regression.py b/tools/run-bisect-perf-regression.py
index 306b345efa630fca732e389a9a0ff847a1148ba6..38b5cbf31272a56a1381fb1336560efbd060de42 100755
--- a/tools/run-bisect-perf-regression.py
+++ b/tools/run-bisect-perf-regression.py
@@ -91,6 +91,11 @@ def RunBisectionScript(config, working_directory, path_to_file, path_to_goma):
cmd.append('--use_goma')
+ # Sometimes goma is lingering around if something went bad on a previous
+ # run. Stop it before starting a new process. Can ignore the return code
+ # since it will return an error if it wasn't running.
+ subprocess.call([goma_file, 'stop'])
+
return_code = subprocess.call([goma_file, 'start'])
if return_code:
print 'Error: goma failed to start.'
« no previous file with comments | « tools/prepare-bisect-perf-regression.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698