Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Side by Side Diff: tools/run-bisect-perf-regression.py

Issue 12780015: Added call to stop goma in case it's still running from a build that timed out. Added --verbose par… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/prepare-bisect-perf-regression.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Run Performance Test Bisect Tool 6 """Run Performance Test Bisect Tool
7 7
8 This script is used by a trybot to run the src/tools/bisect-perf-regression.py 8 This script is used by a trybot to run the src/tools/bisect-perf-regression.py
9 script with the parameters specified in run-bisect-perf-regression.cfg. It will 9 script with the parameters specified in run-bisect-perf-regression.cfg. It will
10 check out a copy of the depot in a subdirectory 'bisect' of the working 10 check out a copy of the depot in a subdirectory 'bisect' of the working
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 if os.name == 'nt': 84 if os.name == 'nt':
85 os.environ['CC'] = os.path.join(path_to_goma, 'gomacc.exe') + ' cl.exe' 85 os.environ['CC'] = os.path.join(path_to_goma, 'gomacc.exe') + ' cl.exe'
86 os.environ['CXX'] = os.path.join(path_to_goma, 'gomacc.exe') + ' cl.exe' 86 os.environ['CXX'] = os.path.join(path_to_goma, 'gomacc.exe') + ' cl.exe'
87 goma_file = os.path.join(path_to_goma, 'goma_ctl.bat') 87 goma_file = os.path.join(path_to_goma, 'goma_ctl.bat')
88 else: 88 else:
89 os.environ['PATH'] = os.pathsep.join([path_to_goma, os.environ['PATH']]) 89 os.environ['PATH'] = os.pathsep.join([path_to_goma, os.environ['PATH']])
90 goma_file = os.path.join(path_to_goma, 'goma_ctl.sh') 90 goma_file = os.path.join(path_to_goma, 'goma_ctl.sh')
91 91
92 cmd.append('--use_goma') 92 cmd.append('--use_goma')
93 93
94 # Sometimes goma is lingering around if something went bad on a previous
95 # run. Stop it before starting a new process. Can ignore the return code
96 # since it will return an error if it wasn't running.
97 subprocess.call([goma_file, 'stop'])
98
94 return_code = subprocess.call([goma_file, 'start']) 99 return_code = subprocess.call([goma_file, 'start'])
95 if return_code: 100 if return_code:
96 print 'Error: goma failed to start.' 101 print 'Error: goma failed to start.'
97 print 102 print
98 return return_code 103 return return_code
99 104
100 cmd = [str(c) for c in cmd] 105 cmd = [str(c) for c in cmd]
101 106
102 return_code = subprocess.call(cmd) 107 return_code = subprocess.call(cmd)
103 108
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 print 'Error: Could not load config file.' 148 print 'Error: Could not load config file.'
144 print 149 print
145 return 1 150 return 1
146 151
147 return RunBisectionScript(config, opts.working_directory, path_to_file, 152 return RunBisectionScript(config, opts.working_directory, path_to_file,
148 opts.path_to_goma) 153 opts.path_to_goma)
149 154
150 155
151 if __name__ == '__main__': 156 if __name__ == '__main__':
152 sys.exit(main()) 157 sys.exit(main())
OLDNEW
« no previous file with comments | « tools/prepare-bisect-perf-regression.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698